Add QuicStrCat.

net/quic/core/quic_stream_sequencer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/core/quic_stream_sequencer.h"
 
 #include <algorithm>
 #include <limits>
 #include <string>
 #include <utility>
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "net/quic/core/quic_bug_tracker.h"
 #include "net/quic/core/quic_flags.h"
 #include "net/quic/core/quic_packets.h"
 #include "net/quic/core/quic_stream.h"
 #include "net/quic/core/quic_stream_sequencer_buffer.h"
 #include "net/quic/core/quic_utils.h"
 #include "net/quic/platform/api/quic_clock.h"
+#include "net/quic/platform/api/quic_str_cat.h"
 
 using base::IntToString;
 using base::StringPiece;
 using base::StringPrintf;
 using std::string;
 
 namespace net {
 
 QuicStreamSequencer::QuicStreamSequencer(QuicStream* quic_stream,
                                          const QuicClock* clock)
@@ skipping 18 matching lines @@
     if (data_len == 0) {
       return;
     }
   }
   size_t bytes_written;
   string error_details;
   QuicErrorCode result = buffered_frames_.OnStreamData(
       byte_offset, StringPiece(frame.data_buffer, frame.data_length),
       clock_->ApproximateNow(), &bytes_written, &error_details);
   if (result != QUIC_NO_ERROR) {
-    string details = "Stream" + base::Uint64ToString(stream_->id()) + ": " +
-                     QuicErrorCodeToString(result) + ": " + error_details +
-                     "\nPeer Address: " +
-                     stream_->PeerAddressOfLatestPacket().ToString();
+    string details = QuicStrCat(
+        "Stream ", stream_->id(), ": ", QuicErrorCodeToString(result), ": ",
+        error_details, "\nPeer Address: ",
+        stream_->PeerAddressOfLatestPacket().ToString());
     DLOG(WARNING) << QuicErrorCodeToString(result);
     DLOG(WARNING) << details;
     stream_->CloseConnectionWithDetails(result, details);
     return;
   }
 
   if (bytes_written == 0) {
     ++num_duplicate_frames_received_;
     // Silently ignore duplicates.
     return;
@@ skipping 60 matching lines @@
   return buffered_frames_.GetReadableRegion(iov, timestamp);
 }
 
 int QuicStreamSequencer::Readv(const struct iovec* iov, size_t iov_len) {
   DCHECK(!blocked_);
   string error_details;
   size_t bytes_read;
   QuicErrorCode read_error =
       buffered_frames_.Readv(iov, iov_len, &bytes_read, &error_details);
   if (read_error != QUIC_NO_ERROR) {
-    string details = StringPrintf("Stream %" PRIu32 ": %s", stream_->id(),
-                                  error_details.c_str());
+    string details = QuicStrCat("Stream ", stream_->id(), ": ", error_details);
     stream_->CloseConnectionWithDetails(read_error, details);
     return static_cast<int>(bytes_read);
   }
 
   stream_->AddBytesConsumed(bytes_read);
   return static_cast<int>(bytes_read);
 }
 
 bool QuicStreamSequencer::HasBytesToRead() const {
   return buffered_frames_.HasBytesToRead();
@@ skipping 58 matching lines @@
 size_t QuicStreamSequencer::NumBytesBuffered() const {
   return buffered_frames_.BytesBuffered();
 }
 
 QuicStreamOffset QuicStreamSequencer::NumBytesConsumed() const {
   return buffered_frames_.BytesConsumed();
 }
 
 const string QuicStreamSequencer::DebugString() const {
   // clang-format off
-  return "QuicStreamSequencer:"
-         "\n  bytes buffered: " + IntToString(NumBytesBuffered()) +
-         "\n  bytes consumed: " + IntToString( NumBytesConsumed()) +
-         "\n  has bytes to read: " +  (HasBytesToRead() ? "true" : "false") +
-         "\n  frames received: " + IntToString(num_frames_received()) +
-         "\n  close offset bytes: " + IntToString( close_offset_) +
-         "\n  is closed: " + (IsClosed() ? "true" : "false");
+  return QuicStrCat("QuicStreamSequencer:",
+                "\n  bytes buffered: ", NumBytesBuffered(),
+                "\n  bytes consumed: ", NumBytesConsumed(),
+                "\n  has bytes to read: ", HasBytesToRead() ? "true" : "false",
+                "\n  frames received: ", num_frames_received(),
+                "\n  close offset bytes: ", close_offset_,
+                "\n  is closed: ", IsClosed() ? "true" : "false");
   // clang-format on
 }
 
 }  // namespace net