Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: components/omnibox/browser/omnibox_field_trial.h

Issue 2591053002: Show PhysicalWebProvider suggestions with omnibox input (Closed)
Patch Set: clear had_physical_web_suggestions_ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/omnibox_field_trial.h
diff --git a/components/omnibox/browser/omnibox_field_trial.h b/components/omnibox/browser/omnibox_field_trial.h
index 46b8f490f14c55bffae193382be1f9add07869c4..e6743d45dfc4e1da19a9eb28c6d72b076ebb5298 100644
--- a/components/omnibox/browser/omnibox_field_trial.h
+++ b/components/omnibox/browser/omnibox_field_trial.h
@@ -374,6 +374,26 @@ class OmniboxFieldTrial {
metrics::OmniboxInputType::Type input_type);
// ---------------------------------------------------------
+ // For PhysicalWebProvider related experiments.
+
+ // Returns whether the user is in a Physical Web field trial where the
+ // PhysicalWebProvider should be used to get suggestions when the user clicks
+ // on the omnibox but has not typed anything yet.
+ static bool InPhysicalWebZeroSuggestFieldTrial();
+
+ // Returns whether the user is in a Physical Web field trial and URL-based
+ // suggestions can continue to appear after the user has started typing.
+ static bool InPhysicalWebAfterTypingFieldTrial();
+
+ // Returns the base relevance score for Physical Web omnibox suggestions when
+ // the user has clicked on the omnibox but has not typed anything yet.
+ static int GetPhysicalWebZeroSuggestBaseRelevance();
+
+ // Returns the base relevance score for Physical Web omnibox suggestions when
+ // the user has started typing in the omnibox.
+ static int GetPhysicalWebAfterTypingBaseRelevance();
+
+ // ---------------------------------------------------------
// Exposed publicly for the sake of unittests.
static const char kBundledExperimentFieldTrialName[];
// Rule names used by the bundled experiment.
@@ -405,6 +425,8 @@ class OmniboxFieldTrial {
static const char kKeywordScoreForSufficientlyCompleteMatchRule[];
static const char kHQPAllowDupMatchesForScoringRule[];
static const char kEmphasizeTitlesRule[];
+ static const char kPhysicalWebZeroSuggestRule[];
+ static const char kPhysicalWebAfterTypingRule[];
// Parameter names used by the HUP new scoring experiments.
static const char kHUPNewScoringEnabledParam[];
@@ -421,6 +443,11 @@ class OmniboxFieldTrial {
static const char kHQPExperimentalScoringBucketsParam[];
static const char kHQPExperimentalScoringTopicalityThresholdParam[];
+ // Parameter names used by the Physical Web experimental scoring experiments.
+ static const char kPhysicalWebExperimentalScoringParam[];
Mark P 2016/12/22 04:58:16 nit: no longer needed
mattreynolds 2017/01/04 01:04:03 Done.
+ static const char kPhysicalWebZeroSuggestBaseRelevanceParam[];
+ static const char kPhysicalWebAfterTypingBaseRelevanceParam[];
+
// The amount of time to wait before sending a new suggest request after the
// previous one unless overridden by a field trial parameter.
// Non-const because some unittests modify this value.

Powered by Google App Engine
This is Rietveld 408576698