Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: components/omnibox/browser/physical_web_provider.h

Issue 2591053002: Show PhysicalWebProvider suggestions with omnibox input (Closed)
Patch Set: debase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/physical_web_provider.h
diff --git a/components/omnibox/browser/physical_web_provider.h b/components/omnibox/browser/physical_web_provider.h
index f67f0c45d77eb871fb1f7f1af1d173109baa0306..201657ccb2ecc169db60c991050239321d5191db 100644
--- a/components/omnibox/browser/physical_web_provider.h
+++ b/components/omnibox/browser/physical_web_provider.h
@@ -6,6 +6,7 @@
#define COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_
#include "base/macros.h"
+#include "components/bookmarks/browser/titled_url_match.h"
#include "components/omnibox/browser/autocomplete_input.h"
#include "components/omnibox/browser/autocomplete_provider.h"
@@ -43,11 +44,21 @@ class PhysicalWebProvider : public AutocompleteProvider {
HistoryURLProvider* history_url_provider);
~PhysicalWebProvider() override;
- // Adds a separate match item to |matches_| for each nearby URL in
- // |metadata_list|, up to the maximum number of matches allowed. If the total
- // number of nearby URLs exceeds this limit, one match is used for an overflow
- // item.
- void ConstructMatches(base::ListValue* metadata_list);
+ // When the user has focused the omnibox but not yet entered any text (ie,
Mark P 2016/12/21 18:57:50 nit: ie -> i.e. ditto below
mattreynolds 2016/12/21 22:25:58 Done.
+ // the Zero Suggest case), calling this method adds a separate match item to
+ // |matches_| for each nearby URL in |metadata_list|, up to the maximum number
+ // of matches allowed. If the total number of nearby URLs exceeds this limit,
+ // one match is used for an overflow item.
+ void ConstructZeroSuggestMatches(
+ std::unique_ptr<base::ListValue> metadata_list);
+
+ // When the user has entered text into the omnibox (ie, the Query Suggest
+ // case), calling this method adds a separate match item to |matches_| for
+ // each nearby URL in |metadata_list| that matches all of the query terms in
+ // |input|, up to the maximum number of matches allowed.
+ void ConstructQuerySuggestMatches(
+ std::unique_ptr<base::ListValue> metadata_list,
+ const AutocompleteInput& input);
// Adds an overflow match item to |matches_| with a relevance score equal to
// |relevance| and a label indicating there are |additional_url_count| more

Powered by Google App Engine
This is Rietveld 408576698