Fix use-after-scope bug in TextElider.

ui/gfx/text_elider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file implements utility functions for eliding and formatting UI text.
 //
 // Note that several of the functions declared in text_elider.h are implemented
 // in this file using helper classes in an unnamed namespace.
 
 #include "ui/gfx/text_elider.h"
@@ skipping 760 matching lines @@
 
   int32_t index = static_cast<int32_t>(length - 1);
   if (word_break) {
     // Use a word iterator to find the first boundary.
     UErrorCode status = U_ZERO_ERROR;
     std::unique_ptr<icu::BreakIterator> bi(
         icu::RuleBasedBreakIterator::createWordInstance(
             icu::Locale::getDefault(), status));
     if (U_FAILURE(status))
       return string.substr(0, length - 1) + kElideString;
-    bi->setText(string.c_str());
+    icu::UnicodeString bi_text(string.c_str());
+    bi->setText(bi_text);
     index = bi->preceding(static_cast<int32_t>(length));
     if (index == icu::BreakIterator::DONE || index == 0) {
       // We either found no valid word break at all, or one right at the
       // beginning of the string. Go back to the end; we'll have to break in the
       // middle of a word.
       index = static_cast<int32_t>(length - 1);
     }
   }
 
   // By this point, |index| should point at the character that's a candidate for
@@ skipping 19 matching lines @@
   // of, and we can fit at least one character of the word in the elided string.
   // Do that rather than just returning an ellipsis.
   if (word_break && (index != static_cast<int32_t>(length - 1)))
     return string.substr(0, length - 1) + kElideString;
 
   // Trying to break after only whitespace, elide all of it.
   return kElideString;
 }
 
 }  // namespace gfx