Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: cc/scheduler/scheduler.cc

Issue 2591013004: [cc] Add and use BeginFrameAck for DidFinishFrame. (Closed)
Patch Set: remove ipc struct traits for BeginFrameAck. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/begin_frame_source_unittest.cc ('k') | cc/scheduler/scheduler_state_machine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/scheduler.cc
diff --git a/cc/scheduler/scheduler.cc b/cc/scheduler/scheduler.cc
index 14d5e69e6a0b6521be64398bb0755aca1ce5e559..d8f9440227d4b858b6190b63fe3baab87aa513c9 100644
--- a/cc/scheduler/scheduler.cc
+++ b/cc/scheduler/scheduler.cc
@@ -322,7 +322,10 @@ void Scheduler::BeginImplFrameWithDeadline(const BeginFrameArgs& args) {
// Discard missed begin frames if they are too late.
if (adjusted_args.type == BeginFrameArgs::MISSED &&
now > adjusted_args.deadline) {
- begin_frame_source_->DidFinishFrame(this, 0);
+ // TODO(eseckler): Determine and set correct |ack.latest_confirmed_frame|.
+ BeginFrameAck ack(adjusted_args.source_id, adjusted_args.sequence_number,
+ adjusted_args.sequence_number, 0, false);
+ begin_frame_source_->DidFinishFrame(this, ack);
return;
}
@@ -332,7 +335,10 @@ void Scheduler::BeginImplFrameWithDeadline(const BeginFrameArgs& args) {
OnBeginImplFrameDeadline();
// We may not need begin frames any longer.
if (!observing_begin_frame_source_) {
- begin_frame_source_->DidFinishFrame(this, 0);
+ // TODO(eseckler): Determine and set correct |ack.latest_confirmed_frame|.
+ BeginFrameAck ack(adjusted_args.source_id, adjusted_args.sequence_number,
+ adjusted_args.sequence_number, 0, false);
+ begin_frame_source_->DidFinishFrame(this, ack);
return;
}
}
@@ -391,8 +397,12 @@ void Scheduler::BeginImplFrameWithDeadline(const BeginFrameArgs& args) {
can_activate_before_deadline)) {
TRACE_EVENT_INSTANT0("cc", "SkipBeginImplFrameToReduceLatency",
TRACE_EVENT_SCOPE_THREAD);
- if (begin_frame_source_)
- begin_frame_source_->DidFinishFrame(this, 0);
+ if (begin_frame_source_) {
+ // TODO(eseckler): Determine and set correct |ack.latest_confirmed_frame|.
+ BeginFrameAck ack(adjusted_args.source_id, adjusted_args.sequence_number,
+ adjusted_args.sequence_number, 0, false);
+ begin_frame_source_->DidFinishFrame(this, ack);
+ }
return;
}
@@ -420,8 +430,14 @@ void Scheduler::FinishImplFrame() {
ProcessScheduledActions();
client_->DidFinishImplFrame();
- if (begin_frame_source_)
- begin_frame_source_->DidFinishFrame(this, 0);
+ if (begin_frame_source_) {
+ // TODO(eseckler): Determine and set correct |ack.latest_confirmed_frame|.
+ BeginFrameAck ack(begin_main_frame_args_.source_id,
+ begin_main_frame_args_.sequence_number,
+ begin_main_frame_args_.sequence_number, 0,
+ state_machine_.did_submit_in_last_frame());
+ begin_frame_source_->DidFinishFrame(this, ack);
+ }
begin_impl_frame_tracker_.Finish();
}
« no previous file with comments | « cc/scheduler/begin_frame_source_unittest.cc ('k') | cc/scheduler/scheduler_state_machine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698