Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: content/renderer/gpu/compositor_external_begin_frame_source.h

Issue 2591013004: [cc] Add and use BeginFrameAck for DidFinishFrame. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_ 5 #ifndef CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_
6 #define CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_ 6 #define CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_
7 7
8 #include <unordered_set> 8 #include <unordered_set>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 25 matching lines...) Expand all
36 explicit CompositorExternalBeginFrameSource( 36 explicit CompositorExternalBeginFrameSource(
37 CompositorForwardingMessageFilter* filter, 37 CompositorForwardingMessageFilter* filter,
38 IPC::SyncMessageFilter* sync_message_filter, 38 IPC::SyncMessageFilter* sync_message_filter,
39 int routing_id); 39 int routing_id);
40 ~CompositorExternalBeginFrameSource() override; 40 ~CompositorExternalBeginFrameSource() override;
41 41
42 // cc::BeginFrameSource implementation. 42 // cc::BeginFrameSource implementation.
43 void AddObserver(cc::BeginFrameObserver* obs) override; 43 void AddObserver(cc::BeginFrameObserver* obs) override;
44 void RemoveObserver(cc::BeginFrameObserver* obs) override; 44 void RemoveObserver(cc::BeginFrameObserver* obs) override;
45 void DidFinishFrame(cc::BeginFrameObserver* obs, 45 void DidFinishFrame(cc::BeginFrameObserver* obs,
46 size_t remaining_frames) override {} 46 const cc::BeginFrameAck& ack) override {}
brianderson 2016/12/21 20:15:06 Are you planning to implement this in a followup p
Eric Seckler 2016/12/22 11:11:48 Yup, together with ack-tracking within ExternalBFS
47 bool IsThrottled() const override; 47 bool IsThrottled() const override;
48 48
49 // cc::ExternalBeginFrameSourceClient implementation. 49 // cc::ExternalBeginFrameSourceClient implementation.
50 void OnNeedsBeginFrames(bool need_begin_frames) override; 50 void OnNeedsBeginFrames(bool need_begin_frames) override;
51 51
52 private: 52 private:
53 class CompositorExternalBeginFrameSourceProxy 53 class CompositorExternalBeginFrameSourceProxy
54 : public base::RefCountedThreadSafe< 54 : public base::RefCountedThreadSafe<
55 CompositorExternalBeginFrameSourceProxy> { 55 CompositorExternalBeginFrameSourceProxy> {
56 public: 56 public:
(...skipping 30 matching lines...) Expand all
87 scoped_refptr<IPC::SyncMessageFilter> message_sender_; 87 scoped_refptr<IPC::SyncMessageFilter> message_sender_;
88 int routing_id_; 88 int routing_id_;
89 CompositorForwardingMessageFilter::Handler begin_frame_source_filter_handler_; 89 CompositorForwardingMessageFilter::Handler begin_frame_source_filter_handler_;
90 90
91 DISALLOW_COPY_AND_ASSIGN(CompositorExternalBeginFrameSource); 91 DISALLOW_COPY_AND_ASSIGN(CompositorExternalBeginFrameSource);
92 }; 92 };
93 93
94 } // namespace content 94 } // namespace content
95 95
96 #endif // CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_ 96 #endif // CONTENT_RENDERER_GPU_COMPOSITOR_EXTERNAL_BEGIN_FRAME_SOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698