Issue 259093003: Revert 266615 "Store default search provider data in dictionary ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 259093003: Revert 266615 "Store default search provider data in dictionary ..." (Closed)

Created:
6 years, 7 months ago by awong

Modified:
6 years, 7 months ago

Reviewers:
Cait (Slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 266615 "Store default search provider data in dictionary ..." Leaking in DefaultSearchManagerTest.ReadAndWritePref. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2042/steps/unit_tests/logs/ReadAndWritePref > Store default search provider data in dictionary pref, and add DefaultSearchManager class to handle the reading and writing of this pref (DefaultSearchManager will eventually all default search related concerns). > > This pref will be used to persist data about user-selected > default search providers. In future CLs, support will be added for default search providers set by policy and sync. > > > BUG=365762 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266479 > > Review URL: https://codereview.chromium.org/229763005 TBR=caitkp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266633

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -401 lines)			Patch
D	trunk/src/chrome/browser/search_engines/default_search_manager.h	View	1 chunk	+0 lines, -73 lines	0 comments	Download
D	trunk/src/chrome/browser/search_engines/default_search_manager.cc	View	1 chunk	+0 lines, -226 lines	0 comments	Download
D	trunk/src/chrome/browser/search_engines/default_search_manager_unittest.cc	View	1 chunk	+0 lines, -84 lines	0 comments	Download
M	trunk/src/chrome/browser/search_engines/template_url_service.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/search_engines/template_url_service.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	trunk/src/chrome/browser/search_engines/template_url_service_factory.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

awong

6 years, 7 months ago (2014-04-28 19:46:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r266633 (tree was closed).