Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: chrome/browser/component_updater/component_unpacker.h

Issue 25909005: Use UtilityProcessHost to patch files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nonblocking
Patch Set: Rebase to LKGR/248226 Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/component_unpacker.h
diff --git a/chrome/browser/component_updater/component_unpacker.h b/chrome/browser/component_updater/component_unpacker.h
index ce722807d8e38dbd630c852e79d22233606076dd..c84282b15d48af6751605fee73bb1dab5325f4a0 100644
--- a/chrome/browser/component_updater/component_unpacker.h
+++ b/chrome/browser/component_updater/component_unpacker.h
@@ -94,16 +94,15 @@ class ComponentUnpacker {
ComponentUnpacker(const std::vector<uint8>& pk_hash,
const base::FilePath& path,
const std::string& fingerprint,
- ComponentPatcher* patcher,
ComponentInstaller* installer,
+ bool in_process,
scoped_refptr<base::SequencedTaskRunner> task_runner);
virtual ~ComponentUnpacker();
// Begins the actual unpacking of the files. May invoke a patcher if the
// package is a differential update. Calls |callback| with the result.
- void Unpack(
- const base::Callback<void(Error, int)>& callback);
+ void Unpack(const base::Callback<void(Error, int)>& callback);
private:
bool UnpackInternal();
@@ -144,9 +143,10 @@ class ComponentUnpacker {
base::FilePath unpack_diff_path_;
bool is_delta_;
std::string fingerprint_;
- ComponentPatcher* patcher_;
+ scoped_ptr<ComponentPatcher> patcher_;
ComponentInstaller* installer_;
base::Callback<void(Error, int)> callback_;
+ bool in_process_;
Sorin Jianu 2014/02/03 20:57:57 const?
waffles 2014/02/07 01:00:59 Done.
Error error_;
int extended_error_;
base::WeakPtrFactory<ComponentUnpacker> ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698