Move mock_special_storage_policy from webkit/ to content/public/test/

Move mock_special_storage_policy from webkit/ to content/public/test/

BUG=338338
TBR=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267345

[jam, 2014-04-29 00:54:04]

https://codereview.chromium.org/259083002/diff/1/content/browser/database_tra...
File content/browser/database_tracker_unittest.cc (right):

https://codereview.chromium.org/259083002/diff/1/content/browser/database_tra...
content/browser/database_tracker_unittest.cc:191: // the F R I E N D_TEST()
macro, and we implement all tests we want to run as
?

https://codereview.chromium.org/259083002/diff/1/content/browser/database_tra...
content/browser/database_tracker_unittest.cc:201:
scoped_refptr<content::MockSpecialStoragePolicy> special_storage_policy =
nit: here and below, get rid of "content::"

https://codereview.chromium.org/259083002/diff/1/content/browser/database_tra...
content/browser/database_tracker_unittest.cc:817: kName);
nit: per style guide, the first parameter on each line has to start at the same
column. so you can either have:

    base::FilePath spoof_db_file2 = tracker->GetFullDBFilePath(
        kOriginId, kName);
or
    base::FilePath spoof_db_file2 = tracker->GetFullDBFilePath(kOriginId,
                                                               kName);

https://codereview.chromium.org/259083002/diff/1/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/259083002/diff/1/content/content_tests.gypi#n...
content/content_tests.gypi:333: 'target_name': 'webkit_test_support_content',
i don't think this target is needed anymore, and you can put these files in
test_support_content target?

[pilgrim_google, 2014-04-29 01:23:16]

On 2014/04/29 00:54:04, jam wrote:
>
https://codereview.chromium.org/259083002/diff/1/content/browser/database_tra...
> File content/browser/database_tracker_unittest.cc (right):
> 
>
https://codereview.chromium.org/259083002/diff/1/content/browser/database_tra...
> content/browser/database_tracker_unittest.cc:191: // the F R I E N D_TEST()
> macro, and we implement all tests we want to run as
> ?

presubmit gave a false positive error about using a banned function even though
it's only mentioned in the comment.

[jam, 2014-04-29 04:27:49]

On 2014/04/29 01:23:16, pilgrim_google wrote:
> On 2014/04/29 00:54:04, jam wrote:
> >
>
https://codereview.chromium.org/259083002/diff/1/content/browser/database_tra...
> > File content/browser/database_tracker_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/259083002/diff/1/content/browser/database_tra...
> > content/browser/database_tracker_unittest.cc:191: // the F R I E N D_TEST()
> > macro, and we implement all tests we want to run as
> > ?
> 
> presubmit gave a false positive error about using a banned function even
though
> it's only mentioned in the comment.

how about committing manually after green runs?

[michaeln, 2014-04-29 18:56:52]

Might work to just nix the ()'s at the end so its not a recurring problem.

>
https://codereview.chromium.org/259083002/diff/1/content/browser/database_tra...
> > > content/browser/database_tracker_unittest.cc:191: // the F R I E N
D_TEST()
> > > macro, and we implement all tests we want to run as
> > > ?
> > 
> > presubmit gave a false positive error about using a banned function even
> though
> > it's only mentioned in the comment.
> 
> how about committing manually after green runs?

[pilgrim_google, 2014-04-29 19:08:28]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2014-04-29 19:10:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pilgrim@chromium.org/259083002/20001

[commit-bot: I haz the power, 2014-04-29 23:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 23:22:47]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium

[pilgrim_google, 2014-04-30 13:09:41]

Please re-review.

[jam, 2014-04-30 16:29:34]

lgtm

[pilgrim_google, 2014-04-30 17:41:35]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2014-04-30 17:42:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pilgrim@chromium.org/259083002/40001

[commit-bot: I haz the power, 2014-04-30 18:23:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 18:23:30]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium

[pilgrim_google, 2014-04-30 18:28:55]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2014-04-30 18:29:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pilgrim@chromium.org/259083002/40001

[commit-bot: I haz the power, 2014-04-30 21:46:27]

Change committed as 267345