Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/protobuf/ruby/ext/google/protobuf_c/message.c

Issue 2590803003: Revert "third_party/protobuf: Update to HEAD (83d681ee2c)" (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/ruby/ext/google/protobuf_c/message.c
diff --git a/third_party/protobuf/ruby/ext/google/protobuf_c/message.c b/third_party/protobuf/ruby/ext/google/protobuf_c/message.c
index 837a974b8379cb562d095b10783e17b512fefe65..e16250f3b07eddfce44d176fb941e49efef95c25 100644
--- a/third_party/protobuf/ruby/ext/google/protobuf_c/message.c
+++ b/third_party/protobuf/ruby/ext/google/protobuf_c/message.c
@@ -178,45 +178,6 @@ VALUE Message_method_missing(int argc, VALUE* argv, VALUE _self) {
}
}
-VALUE Message_respond_to_missing(int argc, VALUE* argv, VALUE _self) {
- MessageHeader* self;
- VALUE method_name, method_str;
- char* name;
- size_t name_len;
- bool setter;
- const upb_oneofdef* o;
- const upb_fielddef* f;
-
- TypedData_Get_Struct(_self, MessageHeader, &Message_type, self);
- if (argc < 1) {
- rb_raise(rb_eArgError, "Expected method name as first argument.");
- }
- method_name = argv[0];
- if (!SYMBOL_P(method_name)) {
- rb_raise(rb_eArgError, "Expected symbol as method name.");
- }
- method_str = rb_id2str(SYM2ID(method_name));
- name = RSTRING_PTR(method_str);
- name_len = RSTRING_LEN(method_str);
- setter = false;
-
- // Setters have names that end in '='.
- if (name[name_len - 1] == '=') {
- setter = true;
- name_len--;
- }
-
- // See if this name corresponds to either a oneof or field in this message.
- if (!upb_msgdef_lookupname(self->descriptor->msgdef, name, name_len, &f,
- &o)) {
- return rb_call_super(argc, argv);
- }
- if (o != NULL) {
- return setter ? Qfalse : Qtrue;
- }
- return Qtrue;
-}
-
int Message_initialize_kwarg(VALUE key, VALUE val, VALUE _self) {
MessageHeader* self;
VALUE method_str;
@@ -344,9 +305,6 @@ VALUE Message_deep_copy(VALUE _self) {
VALUE Message_eq(VALUE _self, VALUE _other) {
MessageHeader* self;
MessageHeader* other;
- if (TYPE(_self) != TYPE(_other)) {
- return Qfalse;
- }
TypedData_Get_Struct(_self, MessageHeader, &Message_type, self);
TypedData_Get_Struct(_other, MessageHeader, &Message_type, other);
@@ -501,8 +459,6 @@ VALUE build_class_from_descriptor(Descriptor* desc) {
rb_define_method(klass, "method_missing",
Message_method_missing, -1);
- rb_define_method(klass, "respond_to_missing?",
- Message_respond_to_missing, -1);
rb_define_method(klass, "initialize", Message_initialize, -1);
rb_define_method(klass, "dup", Message_dup, 0);
// Also define #clone so that we don't inherit Object#clone.
« no previous file with comments | « third_party/protobuf/ruby/ext/google/protobuf_c/map.c ('k') | third_party/protobuf/ruby/ext/google/protobuf_c/protobuf.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698