Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/protobuf/src/google/protobuf/util/internal/default_value_objectwriter_test.cc

Issue 2590803003: Revert "third_party/protobuf: Update to HEAD (83d681ee2c)" (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/src/google/protobuf/util/internal/default_value_objectwriter_test.cc
diff --git a/third_party/protobuf/src/google/protobuf/util/internal/default_value_objectwriter_test.cc b/third_party/protobuf/src/google/protobuf/util/internal/default_value_objectwriter_test.cc
index e1dd697aece9c04f347438afe110d723605135fe..8254c0fa2e1bc40f7e138118e83ff1b8be28476e 100644
--- a/third_party/protobuf/src/google/protobuf/util/internal/default_value_objectwriter_test.cc
+++ b/third_party/protobuf/src/google/protobuf/util/internal/default_value_objectwriter_test.cc
@@ -149,39 +149,6 @@ TEST_P(DefaultValueObjectWriterTest, ShouldRetainUnknownField) {
}
-class DefaultValueObjectWriterSuppressListTest
- : public BaseDefaultValueObjectWriterTest {
- protected:
- DefaultValueObjectWriterSuppressListTest()
- : BaseDefaultValueObjectWriterTest(DefaultValueTest::descriptor()) {
- testing_->set_suppress_empty_list(true);
- }
- ~DefaultValueObjectWriterSuppressListTest() {}
-};
-
-INSTANTIATE_TEST_CASE_P(DifferentTypeInfoSourceTest,
- DefaultValueObjectWriterSuppressListTest,
- ::testing::Values(
- testing::USE_TYPE_RESOLVER));
-
-TEST_P(DefaultValueObjectWriterSuppressListTest, Empty) {
- // Set expectation. Emtpy lists should be suppressed.
- expects_.StartObject("")
- ->RenderDouble("doubleValue", 0.0)
- ->RenderFloat("floatValue", 0.0)
- ->RenderInt64("int64Value", 0)
- ->RenderUint64("uint64Value", 0)
- ->RenderInt32("int32Value", 0)
- ->RenderUint32("uint32Value", 0)
- ->RenderBool("boolValue", false)
- ->RenderString("stringValue", "")
- ->RenderBytes("bytesValue", "")
- ->RenderString("enumValue", "ENUM_FIRST")
- ->EndObject();
-
- // Actual testing
- testing_->StartObject("")->EndObject();
-}
} // namespace testing
} // namespace converter
} // namespace util

Powered by Google App Engine
This is Rietveld 408576698