MD Downloads: gzip vulcanized resources via compress="gzip"

content/public/browser/web_ui_data_source.h

Index: content/public/browser/web_ui_data_source.h
diff --git a/content/public/browser/web_ui_data_source.h b/content/public/browser/web_ui_data_source.h
index bf2db3b3139b69adbdbd4adb49e1a82a80a6a3b1..69084cf3ed2be0af716c117b7819246ceb141a00 100644
--- a/content/public/browser/web_ui_data_source.h
+++ b/content/public/browser/web_ui_data_source.h
@@ -105,9 +105,11 @@ class WebUIDataSource {
       const std::string& data) = 0;
   virtual void DisableDenyXFrameOptions() = 0;
 
-  // Tells the loading code that resources are gzipped on disk. TODO(dbeam):
-  // write a streaming $i18n{} replacer and remove the "DisableI18n" part.
-  virtual void DisableI18nAndUseGzipForAllPaths() = 0;
+  // Tells the loading code that resources are gzipped on disk.
+  virtual void UseGzipForAllPaths() = 0;
+
+  // When UseGzipForAllPaths is enabled, exclude the given |path|.
+  virtual void ExcludePathFromGzip(const std::string& path) = 0;

[jam, 2016/12/21 21:18:31]

do we really need two methods? can't UseGzipForAllPaths just take a vector for
exceptions? then there'd be no need to know what the right order for calling
these methods are etc

[Dan Beam, 2016/12/21 22:22:05]

how does

virtual void UseGzip(const std::vector<std::string>& excluded_paths) = 0;

sound to you?

[Dan Beam, 2016/12/21 23:06:34]

Done. (*except that I forgot excluded_paths_ was implemented as an
unordered_set, which seems fine for this)

 };
 
 }  // namespace content