Issue 259073005: Revert of [Android] Reland "Provide unhandled tap event notifications"

Issue 259073005: Revert of [Android] Reland "Provide unhandled tap event notifications" (Closed)

Created:
6 years, 7 months ago by Michael Achenbach

Modified:
6 years, 7 months ago

Reviewers:
jdduke (slow)

CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of [Android] Reland "Provide unhandled tap event notifications" (https://codereview.chromium.org/256213002/) Reason for revert: The test TouchCursorInTextfieldTest is failing flakily on Linux ChromiumOS Tests (2): http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/23460 The precondition CL crrev.com/218633008 also got previously reverted. Original issue's description: > [Android] Reland "Provide unhandled tap event notifications" > > Allow notifications of unhandled taps via the GestureStateListener. This change > makes GestureTap events blocking, but there are several use-cases for which this > will be necessary, e.g., WebView and contextual search. > > This was landed in r26143 and reverted in r261470 due to to a failure in > TouchEditableImplAuraTest.TouchCursorInTextfieldTest. The test has been fixed > and reviewed previously in crrev.com/218633008. > > BUG=355154 > TBR=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266732 TBR=jdduke@chromium.org NOTREECHECKS=true NOTRY=true BUG=355154 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266832

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -36 lines)			Patch
M	content/browser/android/content_view_core_impl.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/input/input_router_impl_unittest.cc	View	2 chunks	+3 lines, -12 lines	0 comments	Download
M	content/browser/web_contents/touch_editable_impl_aura_browsertest.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	content/common/input/web_input_event_traits.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content_public/browser/GestureStateListener.java	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

Created Revert of [Android] Reland "Provide unhandled tap event notifications"

6 years, 7 months ago (2014-04-29 10:32:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/259073005/1

6 years, 7 months ago (2014-04-29 10:33:04 UTC) #2

Message was sent while issue was closed.

Change committed as 266832