DescriptionRevert of retry r266042: (https://codereview.chromium.org/251703002/)
Reason for revert:
Caused tons of uninitialized reads:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/39582
{
<insert_a_suppression_name_here>
Memcheck:Uninitialized
fun:_ZN11color_utils12SkColorToHSLEjPNS_3HSLE
fun:_ZN11color_utils12_GLOBAL__N_115LumaInvertColorEj
fun:_ZN11color_utils16GetReadableColorEjj
fun:_ZN5views5Label17RecalculateColorsEv
fun:_ZN5views5Label15SetEnabledColorEj
fun:_ZN14message_center12BoundedLabel9SetColorsEjj
fun:_ZN14message_center16NotificationViewC1EPNS_23MessageCenterControllerERKNS_12NotificationE
fun:_ZN14message_center16NotificationView6CreateEPNS_23MessageCenterControllerERKNS_12NotificationEb
fun:_ZN14message_center17MessageCenterView17AddNotificationAtERKNS_12NotificationEi
fun:_ZN14message_center17MessageCenterView16SetNotificationsERKSt3setIPNS_12NotificationENS_30ComparePriorityTimestampSerialESaIS3_EE
fun:_ZN14message_center21MessageCenterViewTest5SetUpEv
}
etc
Original issue's description:
> retry r266042:
> ----------------------
> Automatically call OnNativeThemeChanged when a widget is added to a hierarchy
> with a widget.
>
> Split off from https://codereview.chromium.org/245863002/
>
> BUG=347832
> (tangentially)
> ----------------------
>
> original review: https://codereview.chromium.org/248073005/
> changes: updated views unit tests
>
> R=sky@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266622
TBR=sky@chromium.org,msw@chromium.org,estade@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=347832
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266658
Patch Set 1 #
Created: 6 years, 7 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|