Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issue 259073004: Revert of retry r266042: (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
Reviewers:
msw, sky, Evan Stade
CC:
chromium-reviews, tdanderson+views_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, benquan, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, ben+views_chromium.org, James Su, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Revert of retry r266042: (https://codereview.chromium.org/251703002/) Reason for revert: Caused tons of uninitialized reads: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/39582 { <insert_a_suppression_name_here> Memcheck:Uninitialized fun:_ZN11color_utils12SkColorToHSLEjPNS_3HSLE fun:_ZN11color_utils12_GLOBAL__N_115LumaInvertColorEj fun:_ZN11color_utils16GetReadableColorEjj fun:_ZN5views5Label17RecalculateColorsEv fun:_ZN5views5Label15SetEnabledColorEj fun:_ZN14message_center12BoundedLabel9SetColorsEjj fun:_ZN14message_center16NotificationViewC1EPNS_23MessageCenterControllerERKNS_12NotificationE fun:_ZN14message_center16NotificationView6CreateEPNS_23MessageCenterControllerERKNS_12NotificationEb fun:_ZN14message_center17MessageCenterView17AddNotificationAtERKNS_12NotificationEi fun:_ZN14message_center17MessageCenterView16SetNotificationsERKSt3setIPNS_12NotificationENS_30ComparePriorityTimestampSerialESaIS3_EE fun:_ZN14message_center21MessageCenterViewTest5SetUpEv } etc Original issue's description: > retry r266042: > ---------------------- > Automatically call OnNativeThemeChanged when a widget is added to a hierarchy > with a widget. > > Split off from https://codereview.chromium.org/245863002/ > > BUG=347832 > (tangentially) > ---------------------- > > original review: https://codereview.chromium.org/248073005/ > changes: updated views unit tests > > R=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266622 TBR=sky@chromium.org,msw@chromium.org,estade@chromium.org NOTREECHECKS=true NOTRY=true BUG=347832 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -172 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/text_button.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/label.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/label.cc View 3 chunks +24 lines, -19 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 12 chunks +78 lines, -48 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 chunk +12 lines, -5 lines 0 comments Download
M ui/views/controls/styled_label_unittest.cc View 4 chunks +25 lines, -31 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 3 chunks +18 lines, -9 lines 0 comments Download
M ui/views/view.cc View 2 chunks +10 lines, -14 lines 0 comments Download
M ui/views/view_unittest.cc View 4 chunks +1 line, -46 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Created Revert of retry r266042:
6 years, 7 months ago (2014-04-28 21:04:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/259073004/1
6 years, 7 months ago (2014-04-28 21:04:59 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 21:06:20 UTC) #3
Message was sent while issue was closed.
Change committed as 266658

Powered by Google App Engine
This is Rietveld 408576698