Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2590613002: Prevent drag-and-drop events from firing over cross-site, same-page frames. (Closed)

Created:
4 years ago by paulmeyer
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Prevent drag-and-drop events from firing over cross-site, same-page frames. This is done by storing the source RenderViewHost and RenderProcessHost for each dragstart. Then, for other drag events (like dragover), if the target frame for that event is in the same RenderViewHost, but different RenderProcessHost, than the source, then the event is not fired. Note that this patch will not affect behavior on Mac, and a subsequent CL will enforce the same thing for Mac. BUG=666858 Review-Url: https://codereview.chromium.org/2568893002 Cr-Commit-Position: refs/heads/master@{#438609} (cherry picked from commit 7dfa247951db2ccb10b8b5276eb58a33cda4728f) Committed: https://chromium.googlesource.com/chromium/src/+/13b936546c5148df17caa25ee744d94307ff9e94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -12 lines) Patch
M content/browser/web_contents/web_contents_view_aura.h View 3 chunks +24 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 12 chunks +42 lines, -7 lines 0 comments Download
M testing/buildbot/filters/site-per-process.interactive_ui_tests.filter View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
paulmeyer
4 years ago (2016-12-19 20:36:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13b936546c5148df17caa25ee744d94307ff9e94.

Powered by Google App Engine
This is Rietveld 408576698