content/renderer/webcrypto/webcrypto_impl_nss.cc - Issue 25906002: [webcrypto] Add JWK import for HMAC and AES-CBC key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/webcrypto/webcrypto_impl_nss.cc

Issue 25906002: [webcrypto] Add JWK import for HMAC and AES-CBC key. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes for eroman, plus additional validation of AES key size Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/webcrypto/webcrypto_impl_nss.cc

diff --git a/content/renderer/webcrypto/webcrypto_impl_nss.cc b/content/renderer/webcrypto/webcrypto_impl_nss.cc

index 2b143a5a49e57975866b8564f82d28db9b43611b..ce481f0e5627abd97563a015ad9acc83b5616d46 100644

--- a/content/renderer/webcrypto/webcrypto_impl_nss.cc

+++ b/content/renderer/webcrypto/webcrypto_impl_nss.cc

@@ -11,6 +11,7 @@

#include <vector>

#include "base/logging.h"

+#include "content/renderer/webcrypto/webcrypto_util.h"

#include "crypto/nss_util.h"

#include "crypto/scoped_nss_types.h"

#include "crypto/secure_util.h"

@@ -170,7 +171,7 @@ bool AesCbcEncryptDecrypt(

return false;

}

- WebCryptoImpl::ShrinkBuffer(buffer, final_output_chunk_len + output_len);

+ ShrinkBuffer(buffer, final_output_chunk_len + output_len);

return true;

}