Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: src/factory.cc

Issue 2590563003: [promises] Remove deferred object (Closed)
Patch Set: Remove comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index a1c3c6d6a1d1493a56beed7a0c719beb9a80bde6..50541a687cf118734d2aec84db2e7d5a159c778f 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -1020,16 +1020,18 @@ Handle<PromiseResolveThenableJobInfo> Factory::NewPromiseResolveThenableJobInfo(
Handle<PromiseReactionJobInfo> Factory::NewPromiseReactionJobInfo(
Handle<JSPromise> promise, Handle<Object> value, Handle<Object> tasks,
- Handle<Object> deferred, Handle<Object> debug_id, Handle<Object> debug_name,
- Handle<Context> context) {
+ Handle<Object> deferred_promise, Handle<Object> deferred_on_resolve,
+ Handle<Object> deferred_on_reject, Handle<Context> context) {
Handle<PromiseReactionJobInfo> result = Handle<PromiseReactionJobInfo>::cast(
NewStruct(PROMISE_REACTION_JOB_INFO_TYPE));
result->set_promise(*promise);
result->set_value(*value);
result->set_tasks(*tasks);
- result->set_deferred(*deferred);
- result->set_debug_id(*debug_id);
- result->set_debug_name(*debug_name);
+ result->set_deferred_promise(*deferred_promise);
+ result->set_deferred_on_resolve(*deferred_on_resolve);
+ result->set_deferred_on_reject(*deferred_on_reject);
+ result->set_debug_id(isolate()->heap()->undefined_value());
+ result->set_debug_name(isolate()->heap()->undefined_value());
result->set_context(*context);
return result;
}
« src/builtins/builtins-promise.cc ('K') | « src/factory.h ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698