Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Unified Diff: test/cctest/test-code-stub-assembler.cc

Issue 2590563003: [promises] Remove deferred object (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-promise.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-code-stub-assembler.cc
diff --git a/test/cctest/test-code-stub-assembler.cc b/test/cctest/test-code-stub-assembler.cc
index 72f18d815cd0975a713a3fa2b77e04755103b82a..e1d6d4997b94217c0e9855e6a612df1af3d8108d 100644
--- a/test/cctest/test-code-stub-assembler.cc
+++ b/test/cctest/test-code-stub-assembler.cc
@@ -1904,11 +1904,12 @@ TEST(AllocatePromiseReactionJobInfo) {
Node* const promise = m.AllocateJSPromise(context);
Node* const tasks = m.AllocateFixedArray(FAST_ELEMENTS, m.IntPtrConstant(1));
m.StoreFixedArrayElement(tasks, 0, m.UndefinedConstant());
- Node* const deferred =
+ Node* const deferred_promise =
m.AllocateFixedArray(FAST_ELEMENTS, m.IntPtrConstant(1));
- m.StoreFixedArrayElement(deferred, 0, m.UndefinedConstant());
- Node* const info = m.AllocatePromiseReactionJobInfo(m.SmiConstant(1), promise,
- tasks, deferred, context);
+ m.StoreFixedArrayElement(deferred_promise, 0, m.UndefinedConstant());
+ Node* const info = m.AllocatePromiseReactionJobInfo(
+ promise, m.SmiConstant(1), tasks, deferred_promise, m.UndefinedConstant(),
+ m.UndefinedConstant(), context);
m.Return(info);
Handle<Code> code = data.GenerateCode();
@@ -1923,7 +1924,9 @@ TEST(AllocatePromiseReactionJobInfo) {
CHECK_EQ(Smi::FromInt(1), promise_info->value());
CHECK(promise_info->promise()->IsJSPromise());
CHECK(promise_info->tasks()->IsFixedArray());
- CHECK(promise_info->deferred()->IsFixedArray());
+ CHECK(promise_info->deferred_promise()->IsFixedArray());
+ CHECK(promise_info->deferred_on_resolve()->IsUndefined(isolate));
+ CHECK(promise_info->deferred_on_reject()->IsUndefined(isolate));
CHECK(promise_info->context()->IsContext());
CHECK(promise_info->debug_id()->IsUndefined(isolate));
CHECK(promise_info->debug_name()->IsUndefined(isolate));
« no previous file with comments | « src/runtime/runtime-promise.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698