Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chromeos/components/tether/ble_advertisement_device_queue_unittest.cc

Issue 2590553003: [CrOS Tether] Create ble_constants.h/cc, which include common constants to be shared among multiple… (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
diff --git a/chromeos/components/tether/ble_advertisement_device_queue_unittest.cc b/chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
index 6ba67b88bcf8a3f3445f222f330085cf9ff4dd5d..e24bba436315f743851e73c56b6ef7634bd23ffa 100644
--- a/chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
+++ b/chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
@@ -6,6 +6,7 @@
#include <memory>
+#include "chromeos/components/tether/ble_constants.h"
#include "components/cryptauth/remote_device_test_util.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -94,9 +95,9 @@ TEST_F(BleAdvertisementDeviceQueueTest, TestTwoDevices_MoveToEnd) {
}
TEST_F(BleAdvertisementDeviceQueueTest, TestThreeDevices) {
- // Note: These tests need to be rewritten if MAX_CONCURRENT_ADVERTISEMENTS is
+ // Note: These tests need to be rewritten if |kMaxConcurrentAdvertisements| is
// ever changed.
- ASSERT_GT(3, BleAdvertisementDeviceQueue::kMaxConcurrentAdvertisements);
+ ASSERT_GT(3, kMaxConcurrentAdvertisements);
std::vector<cryptauth::RemoteDevice> devices =
cryptauth::GenerateTestRemoteDevices(3);
@@ -121,9 +122,9 @@ TEST_F(BleAdvertisementDeviceQueueTest, TestThreeDevices) {
}
TEST_F(BleAdvertisementDeviceQueueTest, TestAddingDevices) {
- // Note: These tests need to be rewritten if MAX_CONCURRENT_ADVERTISEMENTS is
+ // Note: These tests need to be rewritten if |kMaxConcurrentAdvertisements| is
// ever changed.
- ASSERT_GT(3, BleAdvertisementDeviceQueue::kMaxConcurrentAdvertisements);
+ ASSERT_GT(3, kMaxConcurrentAdvertisements);
std::vector<cryptauth::RemoteDevice> all_devices =
cryptauth::GenerateTestRemoteDevices(5);

Powered by Google App Engine
This is Rietveld 408576698