third_party/WebKit/LayoutTests/svg/dom/integer-optional-integer-value-range.html - Issue 2590433002: Stricter float-to-int conversion in SVGIntegerOptionalInteger

Side by Side Diff: third_party/WebKit/LayoutTests/svg/dom/integer-optional-integer-value-range.html

Issue 2590433002: Stricter float-to-int conversion in SVGIntegerOptionalInteger (Closed)

Patch Set: ...and back to doing things differently. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	pdr. 2016/12/19 19:42:54 Please don't rewrite this, but for future patches Please don't rewrite this, but for future patches like this, can you try creating unittests instead of layouttests? fs 2016/12/19 19:54:54 The reason for adding a layout test here is becaus Show quoted text On 2016/12/19 at 19:42:54, pdr (OOO Dec 23 to Jan 2) wrote: > Please don't rewrite this, but for future patches like this, can you try creating unittests instead of layouttests? The reason for adding a layout test here is because it's web exposed behavior. I find that unit tests are not as well suitable for those types of tests. (As an example, Gecko passes the first of tests but fails the second - likely because they store a [clamped] float value. I've considered doing that as well.) pdr. 2016/12/19 20:01:51 In terms of web exposed behavior, unittests and la Show quoted text On 2016/12/19 at 19:54:54, fs wrote: > On 2016/12/19 at 19:42:54, pdr (OOO Dec 23 to Jan 2) wrote: > > Please don't rewrite this, but for future patches like this, can you try creating unittests instead of layouttests? > > The reason for adding a layout test here is because it's web exposed behavior. I find that unit tests are not as well suitable for those types of tests. (As an example, Gecko passes the first of tests but fails the second - likely because they store a [clamped] float value. I've considered doing that as well.) In terms of web exposed behavior, unittests and layouttests should be equivalent with a possible exception of running javascript. Do you mean that it's just easier to test against firefox if we use an html file? fs 2016/12/19 20:16:23 Yes, that's a large part of it. It also makes sure Show quoted text On 2016/12/19 at 20:01:51, pdr (OOO Dec 23 to Jan 2) wrote: > On 2016/12/19 at 19:54:54, fs wrote: > > On 2016/12/19 at 19:42:54, pdr (OOO Dec 23 to Jan 2) wrote: > > > Please don't rewrite this, but for future patches like this, can you try creating unittests instead of layouttests? > > > > The reason for adding a layout test here is because it's web exposed behavior. I find that unit tests are not as well suitable for those types of tests. (As an example, Gecko passes the first of tests but fails the second - likely because they store a [clamped] float value. I've considered doing that as well.) > > In terms of web exposed behavior, unittests and layouttests should be equivalent with a possible exception of running javascript. Do you mean that it's just easier to test against firefox if we use an html file? Yes, that's a large part of it. It also makes sure we don't miss to consider any WebIDL behavior (easily forgotten in a unit test.)
	2 <title>SVGIntegerOptionalInteger value range</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6 test(function() {

	7 var element = document.createElementNS('http://www.w3.org/2000/svg', 'feConvol veMatrix');

	8 element.setAttribute('order', '2147483648');

	9 assert_equals(element.orderX.baseVal, 2147483647);

	10

	11 element.setAttribute('order', '-2147483649');

	12 assert_equals(element.orderX.baseVal, -2147483648);

	13 }, document.title+', outside range of int.');

	14

	15 test(function() {

	16 var element = document.createElementNS('http://www.w3.org/2000/svg', 'feConvol veMatrix');

	17 element.setAttribute('order', '2147483578');

	18 assert_equals(element.orderX.baseVal, 2147483647);

	19 }, document.title+', not exactly representable as int.');

	20 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGIntegerOptionalInteger.cpp » ('j') | no next file with comments »