Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 25904004: Add --disable-compositor-touch-hit-testing flag (Closed)

Created:
7 years, 2 months ago by Rick Byers
Modified:
7 years, 2 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org, davemoore+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Add --disable-compositor-touch-hit-testing flag Plumb the flag to blink and the compositor. Disable by default in Android webview for now. Depends on blink CL: https://src.chromium.org/viewvc/blink?view=rev&revision=158956 BUG=303945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227511

Patch Set 1 #

Patch Set 2 : Disable touch hit testing flag: merge with trunk #

Patch Set 3 : Disable touch hit testing flag: fix uninitialized variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M cc/base/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/web_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Rick Byers
Alex, Can you please review the chromium side of this patch? I'll have to wait ...
7 years, 2 months ago (2013-10-04 02:10:39 UTC) #1
aelias_OOO_until_Jul13
lgtm. I don't think it's worth adding a test case, particularly as in theory this ...
7 years, 2 months ago (2013-10-04 02:50:01 UTC) #2
Rick Byers
On 2013/10/04 02:50:01, aelias wrote: > lgtm. I don't think it's worth adding a test ...
7 years, 2 months ago (2013-10-04 04:33:47 UTC) #3
darin (slow to review)
On 2013/10/04 04:33:47, Rick Byers wrote: > On 2013/10/04 02:50:01, aelias wrote: > > lgtm. ...
7 years, 2 months ago (2013-10-05 06:13:13 UTC) #4
darin (slow to review)
LGTM
7 years, 2 months ago (2013-10-05 06:14:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/25904004/8001
7 years, 2 months ago (2013-10-07 20:01:45 UTC) #6
Rick Byers
On 2013/10/05 06:13:13, darin wrote: > On 2013/10/04 04:33:47, Rick Byers wrote: > > On ...
7 years, 2 months ago (2013-10-07 20:03:35 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=175733
7 years, 2 months ago (2013-10-07 20:43:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/25904004/33001
7 years, 2 months ago (2013-10-08 04:42:14 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=86617
7 years, 2 months ago (2013-10-08 07:03:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/25904004/33001
7 years, 2 months ago (2013-10-08 09:36:28 UTC) #11
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 14:27:15 UTC) #12
Message was sent while issue was closed.
Change committed as 227511

Powered by Google App Engine
This is Rietveld 408576698