Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1979)

Unified Diff: content/renderer/v8_value_converter_impl_unittest.cc

Issue 259033002: [Android] Implement renderer side of Gin Java Bridge (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use gin::ArrayBufferView instead of blink::WebArrayBufferView in GinJavaBridgeValueConverter Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/v8_value_converter_impl_unittest.cc
diff --git a/content/renderer/v8_value_converter_impl_unittest.cc b/content/renderer/v8_value_converter_impl_unittest.cc
index f6f252d22ffd890d1a460fe30ede5785b25d4dcf..6f1302dd5fcd63d78adf3f85f5d41fefa0f551a0 100644
--- a/content/renderer/v8_value_converter_impl_unittest.cc
+++ b/content/renderer/v8_value_converter_impl_unittest.cc
@@ -732,7 +732,8 @@ class V8ValueConverterOverridingStrategyForTesting
return true;
}
virtual bool FromV8ArrayBuffer(v8::Handle<v8::Object> value,
- base::Value** out) const OVERRIDE {
+ base::Value** out,
+ v8::Isolate* isolate) const OVERRIDE {
*out = NewReferenceValue();
return true;
}
@@ -822,7 +823,8 @@ class V8ValueConverterBypassStrategyForTesting
return false;
}
virtual bool FromV8ArrayBuffer(v8::Handle<v8::Object> value,
- base::Value** out) const OVERRIDE {
+ base::Value** out,
+ v8::Isolate* isolate) const OVERRIDE {
return false;
}
virtual bool FromV8Number(v8::Handle<v8::Number> value,

Powered by Google App Engine
This is Rietveld 408576698