content/renderer/v8_value_converter_impl.h - Issue 259033002: [Android] Implement renderer side of Gin Java Bridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/v8_value_converter_impl.h

Issue 259033002: [Android] Implement renderer side of Gin Java Bridge (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use gin::ArrayBufferView instead of blink::WebArrayBufferView in GinJavaBridgeValueConverter Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/v8_value_converter_impl.h

diff --git a/content/renderer/v8_value_converter_impl.h b/content/renderer/v8_value_converter_impl.h

index d026a18723667c17ac228711ceefc4960455b85a..a5288aecd16866828d0eab10b4d84984b5c27ba0 100644

--- a/content/renderer/v8_value_converter_impl.h

+++ b/content/renderer/v8_value_converter_impl.h

@@ -61,7 +61,8 @@ class CONTENT_EXPORT V8ValueConverterImpl : public V8ValueConverter {

// This will convert objects of type ArrayBuffer or any of the

// ArrayBufferView subclasses.

- base::Value* FromV8ArrayBuffer(v8::Handle<v8::Object> val) const;

+ base::Value* FromV8ArrayBuffer(v8::Handle<v8::Object> val,

+ v8::Isolate* isolate) const;

base::Value* FromV8Object(v8::Handle<v8::Object> object,

FromV8ValueState* state,