content/public/renderer/v8_value_converter.h - Issue 259033002: [Android] Implement renderer side of Gin Java Bridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/v8_value_converter.h

Issue 259033002: [Android] Implement renderer side of Gin Java Bridge (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use gin::ArrayBufferView instead of blink::WebArrayBufferView in GinJavaBridgeValueConverter Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/renderer/v8_value_converter.h

diff --git a/content/public/renderer/v8_value_converter.h b/content/public/renderer/v8_value_converter.h

index 725980e2c7c92df683c5afc32685e530c67cf957..f3fd126931a8ecc4412bc715947b3d43b58da2f8 100644

--- a/content/public/renderer/v8_value_converter.h

+++ b/content/public/renderer/v8_value_converter.h

@@ -55,7 +55,8 @@ class CONTENT_EXPORT V8ValueConverter {

// behavior. v8::Object is passed as ArrayBuffer and ArrayBufferView

// classes are siblings.

virtual bool FromV8ArrayBuffer(v8::Handle<v8::Object> value,

- base::Value** out) const;

+ base::Value** out,

+ v8::Isolate* isolate) const;

// If false is returned, V8ValueConverter proceeds with the default

// behavior. This allows to intercept "non-finite" values and do something