base/id_map.h - Issue 259033002: [Android] Implement renderer side of Gin Java Bridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/id_map.h

Issue 259033002: [Android] Implement renderer side of Gin Java Bridge (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments addressed, test added Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/id_map.h

diff --git a/base/id_map.h b/base/id_map.h

index 27098d29768404f6bae9b87372cf3ef03c857cb6..1c2ddb65345c8c531855735aa4bdddd247f5b375 100644

--- a/base/id_map.h

+++ b/base/id_map.h

@@ -32,8 +32,9 @@ enum IDMapOwnershipSemantics {

// ownership semantics are set to own because pointers will leak.

template<typename T, IDMapOwnershipSemantics OS = IDMapExternalPointer>

class IDMap : public base::NonThreadSafe {

- private:

+ public:

typedef int32 KeyType;

jochen (gone - plz use gerrit) 2014/05/05 10:55:49 nit. empty line after this line

mnaganov (inactive) 2014/05/06 10:54:15 Done.

+ private:

typedef base::hash_map<KeyType, T*> HashTable;

public: