Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.h

Issue 2590293003: [DevTools] Rework DevToolsSession interaction with domain handlers. (Closed)
Patch Set: includes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.h
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.h b/content/browser/devtools/render_frame_devtools_agent_host.h
index a351cf39ca55c6c38e22d2d84cd498ee9f19a82d..00e3cf4ecc27c814566411de4394a3792ebeb40f 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.h
+++ b/content/browser/devtools/render_frame_devtools_agent_host.h
@@ -38,22 +38,6 @@ class NavigationHandle;
class NavigationThrottle;
class RenderFrameHostImpl;
-namespace protocol {
-class DOMHandler;
-class EmulationHandler;
-class InputHandler;
-class InspectorHandler;
-class IOHandler;
-class NetworkHandler;
-class PageHandler;
-class SchemaHandler;
-class SecurityHandler;
-class ServiceWorkerHandler;
-class StorageHandler;
-class TargetHandler;
-class TracingHandler;
-} // namespace protocol
-
class CONTENT_EXPORT RenderFrameDevToolsAgentHost
: public DevToolsAgentHostImpl,
private WebContentsObserver {
@@ -97,8 +81,6 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
bool Close() override;
base::TimeTicks GetLastActivityTime() override;
- bool DispatchProtocolMessage(const std::string& message) override;
-
private:
friend class DevToolsAgentHost;
explicit RenderFrameDevToolsAgentHost(RenderFrameHostImpl*);
@@ -111,9 +93,12 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
RenderFrameHost* host);
// DevToolsAgentHostImpl overrides.
- void Attach() override;
- void Detach() override;
- void InspectElement(int x, int y) override;
+ void AttachSession(DevToolsSession* session) override;
+ void DetachSession(int session_id) override;
+ void InspectElement(DevToolsSession* session, int x, int y) override;
+ bool DispatchProtocolMessage(
+ DevToolsSession* session,
+ const std::string& message) override;
// WebContentsObserver overrides.
void ReadyToCommitNavigation(NavigationHandle* navigation_handle) override;
@@ -180,19 +165,6 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
// Stores per-host state between DisconnectWebContents and ConnectWebContents.
std::unique_ptr<FrameHostHolder> disconnected_;
- std::unique_ptr<protocol::DOMHandler> dom_handler_;
- std::unique_ptr<protocol::InputHandler> input_handler_;
- std::unique_ptr<protocol::InspectorHandler> inspector_handler_;
- std::unique_ptr<protocol::IOHandler> io_handler_;
- std::unique_ptr<protocol::NetworkHandler> network_handler_;
- std::unique_ptr<protocol::PageHandler> page_handler_;
- std::unique_ptr<protocol::SchemaHandler> schema_handler_;
- std::unique_ptr<protocol::SecurityHandler> security_handler_;
- std::unique_ptr<protocol::ServiceWorkerHandler> service_worker_handler_;
- std::unique_ptr<protocol::StorageHandler> storage_handler_;
- std::unique_ptr<protocol::TargetHandler> target_handler_;
- std::unique_ptr<protocol::TracingHandler> tracing_handler_;
- std::unique_ptr<protocol::EmulationHandler> emulation_handler_;
std::unique_ptr<DevToolsFrameTraceRecorder> frame_trace_recorder_;
#if defined(OS_ANDROID)
std::unique_ptr<device::PowerSaveBlocker> power_save_blocker_;
« no previous file with comments | « content/browser/devtools/protocol/tracing_handler.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698