Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: content/browser/devtools/protocol/tracing_handler.h

Issue 2590293003: [DevTools] Rework DevToolsSession interaction with domain handlers. (Closed)
Patch Set: includes Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/tracing_handler.h
diff --git a/content/browser/devtools/protocol/tracing_handler.h b/content/browser/devtools/protocol/tracing_handler.h
index 41250a7defd49b6b38b89dc1aebc8d81cb7e2db4..2b40a01d84a8d4a78eacea929ff29ea06b22fdff 100644
--- a/content/browser/devtools/protocol/tracing_handler.h
+++ b/content/browser/devtools/protocol/tracing_handler.h
@@ -15,6 +15,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/trace_event/trace_event.h"
+#include "content/browser/devtools/protocol/devtools_domain_handler.h"
#include "content/browser/devtools/protocol/tracing.h"
#include "content/common/content_export.h"
#include "content/public/browser/tracing_controller.h"
@@ -26,10 +27,12 @@ class Timer;
namespace content {
class DevToolsIOContext;
+class DevToolsSession;
namespace protocol {
-class TracingHandler : public Tracing::Backend {
+class TracingHandler : public DevToolsDomainHandler,
+ public Tracing::Backend {
public:
enum Target { Browser, Renderer };
TracingHandler(Target target,
@@ -37,7 +40,9 @@ class TracingHandler : public Tracing::Backend {
DevToolsIOContext* io_context);
~TracingHandler() override;
- void Wire(UberDispatcher*);
+ static TracingHandler* FromSession(DevToolsSession* session);
+
+ void Wire(UberDispatcher* dispatcher) override;
Response Disable() override;
void OnTraceDataCollected(const std::string& trace_fragment);
« no previous file with comments | « content/browser/devtools/protocol/tethering_handler.cc ('k') | content/browser/devtools/protocol/tracing_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698