Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: content/browser/devtools/browser_devtools_agent_host.h

Issue 2590293003: [DevTools] Rework DevToolsSession interaction with domain handlers. (Closed)
Patch Set: addressed comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/browser_devtools_agent_host.h
diff --git a/content/browser/devtools/browser_devtools_agent_host.h b/content/browser/devtools/browser_devtools_agent_host.h
index d466a29a7a5fceb779ce1b84726bb34b75cec7c5..8be1ef421b1c947df79b108fd4c030a02a2722e7 100644
--- a/content/browser/devtools/browser_devtools_agent_host.h
+++ b/content/browser/devtools/browser_devtools_agent_host.h
@@ -26,8 +26,11 @@ class BrowserDevToolsAgentHost : public DevToolsAgentHostImpl {
~BrowserDevToolsAgentHost() override;
// DevToolsAgentHostImpl implementation.
- void Attach() override;
- void Detach() override;
+ void AttachSession(DevToolsSession* session) override;
+ void DetachSession(int session_id) override;
+ bool DispatchProtocolMessage(
+ DevToolsSession* session,
+ const std::string& message) override;
// DevToolsAgentHost implementation.
std::string GetType() override;
@@ -36,7 +39,6 @@ class BrowserDevToolsAgentHost : public DevToolsAgentHostImpl {
bool Activate() override;
void Reload() override;
bool Close() override;
- bool DispatchProtocolMessage(const std::string& message) override;
scoped_refptr<base::SingleThreadTaskRunner> tethering_task_runner_;
CreateServerSocketCallback socket_callback_;

Powered by Google App Engine
This is Rietveld 408576698