Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: content/browser/devtools/worker_devtools_agent_host.h

Issue 2590293003: [DevTools] Rework DevToolsSession interaction with domain handlers. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/worker_devtools_agent_host.h
diff --git a/content/browser/devtools/worker_devtools_agent_host.h b/content/browser/devtools/worker_devtools_agent_host.h
index d0926effb057d5c8d49d5b39470a4707c14ee4f5..309b97b5b38c6232629ba8c68c7e304f24c17a6d 100644
--- a/content/browser/devtools/worker_devtools_agent_host.h
+++ b/content/browser/devtools/worker_devtools_agent_host.h
@@ -11,12 +11,6 @@
namespace content {
-namespace protocol {
-class InspectorHandler;
-class NetworkHandler;
-class SchemaHandler;
-}
-
class BrowserContext;
class WorkerDevToolsAgentHost : public DevToolsAgentHostImpl,
@@ -26,11 +20,13 @@ class WorkerDevToolsAgentHost : public DevToolsAgentHostImpl,
// DevToolsAgentHost override.
BrowserContext* GetBrowserContext() override;
- bool DispatchProtocolMessage(const std::string& message) override;
// DevToolsAgentHostImpl overrides.
- void Attach() override;
- void Detach() override;
+ void Attach(DevToolsSession* session) override;
+ void Detach(DevToolsSession* session) override;
+ bool DispatchProtocolMessage(
+ DevToolsSession* session,
+ const std::string& message) override;
// IPC::Listener implementation.
bool OnMessageReceived(const IPC::Message& msg) override;
@@ -66,9 +62,6 @@ class WorkerDevToolsAgentHost : public DevToolsAgentHostImpl,
void WorkerCreated();
void OnDispatchOnInspectorFrontend(const DevToolsMessageChunk& message);
- std::unique_ptr<protocol::InspectorHandler> inspector_handler_;
- std::unique_ptr<protocol::NetworkHandler> network_handler_;
- std::unique_ptr<protocol::SchemaHandler> schema_handler_;
DevToolsMessageChunkProcessor chunk_processor_;
WorkerState state_;
WorkerId worker_id_;

Powered by Google App Engine
This is Rietveld 408576698