Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: content/browser/devtools/protocol/tracing_handler.cc

Issue 2590293003: [DevTools] Rework DevToolsSession interaction with domain handlers. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/protocol/tracing_handler.h" 5 #include "content/browser/devtools/protocol/tracing_handler.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/format_macros.h" 10 #include "base/format_macros.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 111
112 scoped_refptr<DevToolsIOContext::Stream> stream_; 112 scoped_refptr<DevToolsIOContext::Stream> stream_;
113 base::WeakPtr<TracingHandler> tracing_handler_; 113 base::WeakPtr<TracingHandler> tracing_handler_;
114 }; 114 };
115 115
116 } // namespace 116 } // namespace
117 117
118 TracingHandler::TracingHandler(TracingHandler::Target target, 118 TracingHandler::TracingHandler(TracingHandler::Target target,
119 int frame_tree_node_id, 119 int frame_tree_node_id,
120 DevToolsIOContext* io_context) 120 DevToolsIOContext* io_context)
121 : target_(target), 121 : DevToolsDomainHandler(Tracing::Metainfo::domainName),
122 target_(target),
122 io_context_(io_context), 123 io_context_(io_context),
123 frame_tree_node_id_(frame_tree_node_id), 124 frame_tree_node_id_(frame_tree_node_id),
124 did_initiate_recording_(false), 125 did_initiate_recording_(false),
125 return_as_stream_(false), 126 return_as_stream_(false),
126 weak_factory_(this) {} 127 weak_factory_(this) {}
127 128
128 TracingHandler::~TracingHandler() { 129 TracingHandler::~TracingHandler() {
129 } 130 }
130 131
131 void TracingHandler::Wire(UberDispatcher* dispatcher) { 132 void TracingHandler::Wire(UberDispatcher* dispatcher) {
132 frontend_.reset(new Tracing::Frontend(dispatcher->channel())); 133 frontend_.reset(new Tracing::Frontend(dispatcher->channel()));
133 Tracing::Dispatcher::wire(dispatcher, this); 134 Tracing::Dispatcher::wire(dispatcher, this);
134 } 135 }
135 136
137 void TracingHandler::SetRenderFrameHost(RenderFrameHostImpl* host) {
138 }
139
136 Response TracingHandler::Disable() { 140 Response TracingHandler::Disable() {
137 if (did_initiate_recording_) 141 if (did_initiate_recording_)
138 StopTracing(scoped_refptr<TracingController::TraceDataSink>()); 142 StopTracing(scoped_refptr<TracingController::TraceDataSink>());
139 return Response::OK(); 143 return Response::OK();
140 } 144 }
141 145
142 void TracingHandler::OnTraceDataCollected(const std::string& trace_fragment) { 146 void TracingHandler::OnTraceDataCollected(const std::string& trace_fragment) {
143 // Hand-craft protocol notification message so we can substitute JSON 147 // Hand-craft protocol notification message so we can substitute JSON
144 // that we already got as string as a bare object, not a quoted string. 148 // that we already got as string as a bare object, not a quoted string.
145 std::string message( 149 std::string message(
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 355
352 std::string mode; 356 std::string mode;
353 if (tracing_dict->GetString(kRecordModeParam, &mode)) 357 if (tracing_dict->GetString(kRecordModeParam, &mode))
354 tracing_dict->SetString(kRecordModeParam, ConvertFromCamelCase(mode, '-')); 358 tracing_dict->SetString(kRecordModeParam, ConvertFromCamelCase(mode, '-'));
355 359
356 return base::trace_event::TraceConfig(*tracing_dict); 360 return base::trace_event::TraceConfig(*tracing_dict);
357 } 361 }
358 362
359 } // namespace tracing 363 } // namespace tracing
360 } // namespace protocol 364 } // namespace protocol
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698