Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: content/browser/devtools/browser_devtools_agent_host.cc

Issue 2590293003: [DevTools] Rework DevToolsSession interaction with domain handlers. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/browser_devtools_agent_host.h" 5 #include "content/browser/devtools/browser_devtools_agent_host.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/guid.h" 8 #include "base/guid.h"
9 #include "base/json/json_reader.h" 9 #include "base/memory/ptr_util.h"
10 #include "content/browser/devtools/devtools_session.h" 10 #include "content/browser/devtools/devtools_session.h"
11 #include "content/browser/devtools/protocol/io_handler.h" 11 #include "content/browser/devtools/protocol/io_handler.h"
12 #include "content/browser/devtools/protocol/memory_handler.h" 12 #include "content/browser/devtools/protocol/memory_handler.h"
13 #include "content/browser/devtools/protocol/protocol.h" 13 #include "content/browser/devtools/protocol/protocol.h"
14 #include "content/browser/devtools/protocol/system_info_handler.h" 14 #include "content/browser/devtools/protocol/system_info_handler.h"
15 #include "content/browser/devtools/protocol/tethering_handler.h" 15 #include "content/browser/devtools/protocol/tethering_handler.h"
16 #include "content/browser/devtools/protocol/tracing_handler.h" 16 #include "content/browser/devtools/protocol/tracing_handler.h"
17 #include "content/browser/frame_host/frame_tree_node.h" 17 #include "content/browser/frame_host/frame_tree_node.h"
18 18
19 namespace content { 19 namespace content {
20 20
21 scoped_refptr<DevToolsAgentHost> DevToolsAgentHost::CreateForBrowser( 21 scoped_refptr<DevToolsAgentHost> DevToolsAgentHost::CreateForBrowser(
22 scoped_refptr<base::SingleThreadTaskRunner> tethering_task_runner, 22 scoped_refptr<base::SingleThreadTaskRunner> tethering_task_runner,
23 const CreateServerSocketCallback& socket_callback) { 23 const CreateServerSocketCallback& socket_callback) {
24 return new BrowserDevToolsAgentHost(tethering_task_runner, socket_callback); 24 return new BrowserDevToolsAgentHost(tethering_task_runner, socket_callback);
25 } 25 }
26 26
27 BrowserDevToolsAgentHost::BrowserDevToolsAgentHost( 27 BrowserDevToolsAgentHost::BrowserDevToolsAgentHost(
28 scoped_refptr<base::SingleThreadTaskRunner> tethering_task_runner, 28 scoped_refptr<base::SingleThreadTaskRunner> tethering_task_runner,
29 const CreateServerSocketCallback& socket_callback) 29 const CreateServerSocketCallback& socket_callback)
30 : DevToolsAgentHostImpl(base::GenerateGUID()), 30 : DevToolsAgentHostImpl(base::GenerateGUID()),
31 tethering_task_runner_(tethering_task_runner), 31 tethering_task_runner_(tethering_task_runner),
32 socket_callback_(socket_callback) { 32 socket_callback_(socket_callback) {
33 NotifyCreated(); 33 NotifyCreated();
34 } 34 }
35 35
36 BrowserDevToolsAgentHost::~BrowserDevToolsAgentHost() { 36 BrowserDevToolsAgentHost::~BrowserDevToolsAgentHost() {
37 } 37 }
38 38
39 void BrowserDevToolsAgentHost::Attach() { 39 void BrowserDevToolsAgentHost::Attach(DevToolsSession* session) {
40 io_handler_.reset(new protocol::IOHandler(GetIOContext())); 40 session->AddHandler(base::WrapUnique(new protocol::IOHandler(
41 io_handler_->Wire(session()->dispatcher()); 41 GetIOContext())));
42 42 session->AddHandler(base::WrapUnique(new protocol::MemoryHandler()));
43 memory_handler_.reset(new protocol::MemoryHandler()); 43 session->AddHandler(base::WrapUnique(new protocol::SystemInfoHandler()));
44 memory_handler_->Wire(session()->dispatcher()); 44 session->AddHandler(base::WrapUnique(new protocol::TetheringHandler(
45 45 socket_callback_, tethering_task_runner_)));
46 system_info_handler_.reset(new protocol::SystemInfoHandler()); 46 session->AddHandler(base::WrapUnique(new protocol::TracingHandler(
47 system_info_handler_->Wire(session()->dispatcher());
48
49 tethering_handler_.reset(new protocol::TetheringHandler(
50 socket_callback_, tethering_task_runner_));
51 tethering_handler_->Wire(session()->dispatcher());
52
53 tracing_handler_.reset(new protocol::TracingHandler(
54 protocol::TracingHandler::Browser, 47 protocol::TracingHandler::Browser,
55 FrameTreeNode::kFrameTreeNodeInvalidId, 48 FrameTreeNode::kFrameTreeNodeInvalidId,
56 GetIOContext())); 49 GetIOContext())));
57 tracing_handler_->Wire(session()->dispatcher());
58 } 50 }
59 51
60 void BrowserDevToolsAgentHost::Detach() { 52 void BrowserDevToolsAgentHost::Detach(DevToolsSession* session) {
61 io_handler_->Disable();
62 io_handler_.reset();
63 memory_handler_->Disable();
64 memory_handler_.reset();
65 system_info_handler_->Disable();
66 system_info_handler_.reset();
67 tethering_handler_->Disable();
68 tethering_handler_.reset();
69 tracing_handler_->Disable();
70 tracing_handler_.reset();
71 } 53 }
72 54
73 std::string BrowserDevToolsAgentHost::GetType() { 55 std::string BrowserDevToolsAgentHost::GetType() {
74 return kTypeBrowser; 56 return kTypeBrowser;
75 } 57 }
76 58
77 std::string BrowserDevToolsAgentHost::GetTitle() { 59 std::string BrowserDevToolsAgentHost::GetTitle() {
78 return ""; 60 return "";
79 } 61 }
80 62
81 GURL BrowserDevToolsAgentHost::GetURL() { 63 GURL BrowserDevToolsAgentHost::GetURL() {
82 return GURL(); 64 return GURL();
83 } 65 }
84 66
85 bool BrowserDevToolsAgentHost::Activate() { 67 bool BrowserDevToolsAgentHost::Activate() {
86 return false; 68 return false;
87 } 69 }
88 70
89 bool BrowserDevToolsAgentHost::Close() { 71 bool BrowserDevToolsAgentHost::Close() {
90 return false; 72 return false;
91 } 73 }
92 74
93 void BrowserDevToolsAgentHost::Reload() { 75 void BrowserDevToolsAgentHost::Reload() {
94 } 76 }
95 77
96 bool BrowserDevToolsAgentHost::DispatchProtocolMessage( 78 bool BrowserDevToolsAgentHost::DispatchProtocolMessage(
79 DevToolsSession* session,
97 const std::string& message) { 80 const std::string& message) {
98 session()->dispatcher()->dispatch(protocol::StringUtil::parseJSON(message)); 81 int call_id;
82 std::string method;
83 session->Dispatch(message, false, &call_id, &method);
99 return true; 84 return true;
100 } 85 }
101 86
102 } // content 87 } // content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698