Set the default action of the import data dialog to "Import" and

Set the default action of the import data dialog to "Import" and
focus the button.

BUG=19627
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27916

[Evan Stade, 2009-10-02 23:37:10]

On Fri, Oct 2, 2009 at 4:22 PM,  <tony@chromium.org> wrote:
> Reviewers: Evan Stade,
>
> Description:
> Set the default action of the import data dialog to "Import" and
> focus the button.
>
> BUG=19627
>
> Please review this at http://codereview.chromium.org/259028
>
> Affected files:
>  M chrome/browser/gtk/import_dialog_gtk.cc
>
>
> Index: chrome/browser/gtk/import_dialog_gtk.cc
> diff --git a/chrome/browser/gtk/import_dialog_gtk.cc
> b/chrome/browser/gtk/import_dialog_gtk.cc
> index
>
c1cbf35a9ba09bd6a5a497192b9d2e2a24cbd780..52f4dc6ff8f7ad03451ef1efc26ee65de36daeba
> 100644
> --- a/chrome/browser/gtk/import_dialog_gtk.cc
> +++ b/chrome/browser/gtk/import_dialog_gtk.cc
> @@ -42,6 +42,8 @@ ImportDialogGtk::ImportDialogGtk(GtkWindow* parent,
> Profile* profile) :
>   GtkWidget* import_button = gtk_util::AddButtonToDialog(dialog_,
>       l10n_util::GetStringUTF8(IDS_IMPORT_COMMIT).c_str(),
>       GTK_STOCK_APPLY, GTK_RESPONSE_ACCEPT);
> +  GTK_WIDGET_SET_FLAGS(import_button, GTK_CAN_DEFAULT);
> +  gtk_dialog_set_default_response(GTK_DIALOG(dialog_),
> GTK_RESPONSE_ACCEPT);
>
>   // TODO(rahulk): find how to set size properly so that the dialog
>   // box width is at least enough to display full title.
> @@ -98,6 +100,7 @@ ImportDialogGtk::ImportDialogGtk(GtkWindow* parent,
> Profile* profile) :
>       gtk_combo_box_append_text(GTK_COMBO_BOX(combo_),
>                                 WideToUTF8(profile).c_str());
>     }
> +    gtk_widget_grab_focus(import_button);
>   } else {
>     gtk_combo_box_append_text(GTK_COMBO_BOX(combo_),
>         l10n_util::GetStringUTF8(IDS_IMPORT_NO_PROFILE_FOUND).c_str());
>
>
>
why are both changes necessary? set_default is not enough?

-- Evan Stade

[Evan Stade, 2009-10-02 23:37:44]

lgtm

[tony, 2009-10-02 23:40:35]

Yeah, even with set_default, the drop down gets focus.  I looked at a bunch of
our dialogs and it seems to depend on which widgets are in the dialog.  E.g., in
the Passwords and Exceptions dialog, the tab has focus.