Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2590173004: Add missing include to setup_util_unittest.cc. (Closed)

Created:
4 years ago by Wez
Modified:
4 years ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing include to setup_util_unittest.cc. This fixes compilation failure in the official Chrome build for Windows. NO_DEPENDENCY_CHECKS=true BUG=676202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (17 generated)
Wez
PTAL
4 years ago (2016-12-21 01:37:33 UTC) #2
Wez
FYI, marking TBR since at present the official build is broken.
4 years ago (2016-12-21 01:38:53 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2581893002 Patch 60001). Please resolve the dependency and ...
4 years ago (2016-12-21 01:39:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590173004/1
4 years ago (2016-12-21 01:47:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/184718)
4 years ago (2016-12-21 02:03:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590173004/1
4 years ago (2016-12-21 02:11:28 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/212655)
4 years ago (2016-12-21 02:22:41 UTC) #19
pastarmovj
lgtm
4 years ago (2016-12-21 07:14:48 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590173004/1
4 years ago (2016-12-21 07:14:53 UTC) #22
grt (UTC plus 2)
Thanks for taking care of this. LGTM
4 years ago (2016-12-21 07:22:56 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/327473)
4 years ago (2016-12-21 07:31:54 UTC) #26
pastarmovj
On 2016/12/21 07:31:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-12-21 09:31:42 UTC) #27
gab
-self (please don't include two owners for the same thing)
4 years ago (2016-12-21 15:59:25 UTC) #28
Wez
4 years ago (2016-12-21 17:57:30 UTC) #31
On 2016/12/21 09:31:42, pastarmovj (ooo 23.De-3.Ja) wrote:
> On 2016/12/21 07:31:54, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> 
> Hey Wez,
> 
> since this CL seems to have been stuck on the dependent CL I copied it and
> landed a copy of it to fix the builders. Thanks for looking into this! 
> 
> Happy holidays!  :)
> Julian

Awesome - thanks Julian :)

Powered by Google App Engine
This is Rietveld 408576698