|
|
Chromium Code Reviews
DescriptionAdd missing include to setup_util_unittest.cc.
This fixes compilation failure in the official Chrome build for Windows.
NO_DEPENDENCY_CHECKS=true
BUG=676202
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 31 (17 generated)
wez@chromium.org changed reviewers: + gab@chromium.org, pastarmovj@chromium.org
PTAL
The CQ bit was checked by wez@chromium.org to run a CQ dry run
Description was changed from ========== Add missing include to setup_util_unittest.cc. This fixes compilation failure in the official Chrome build for Windows. BUG=676202 ========== to ========== Add missing include to setup_util_unittest.cc. This fixes compilation failure in the official Chrome build for Windows. TBR=gab BUG=676202 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
FYI, marking TBR since at present the official build is broken.
The CQ bit was unchecked by wez@chromium.org
The CQ bit was checked by wez@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2581893002 Patch 60001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Add missing include to setup_util_unittest.cc. This fixes compilation failure in the official Chrome build for Windows. TBR=gab BUG=676202 ========== to ========== Add missing include to setup_util_unittest.cc. This fixes compilation failure in the official Chrome build for Windows. NO_DEPENDENCY_CHECKS=true TBR=gab BUG=676202 ==========
The CQ bit was checked by wez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by wez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pastarmovj@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
grt@chromium.org changed reviewers: + grt@chromium.org
Thanks for taking care of this. LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
On 2016/12/21 07:31:54, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) Hey Wez, since this CL seems to have been stuck on the dependent CL I copied it and landed a copy of it to fix the builders. Thanks for looking into this! Happy holidays! :) Julian
-self (please don't include two owners for the same thing)
gab@chromium.org changed reviewers: - gab@chromium.org
Description was changed from ========== Add missing include to setup_util_unittest.cc. This fixes compilation failure in the official Chrome build for Windows. NO_DEPENDENCY_CHECKS=true TBR=gab BUG=676202 ========== to ========== Add missing include to setup_util_unittest.cc. This fixes compilation failure in the official Chrome build for Windows. NO_DEPENDENCY_CHECKS=true BUG=676202 ==========
On 2016/12/21 09:31:42, pastarmovj (ooo 23.De-3.Ja) wrote: > On 2016/12/21 07:31:54, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) > > Hey Wez, > > since this CL seems to have been stuck on the dependent CL I copied it and > landed a copy of it to fix the builders. Thanks for looking into this! > > Happy holidays! :) > Julian Awesome - thanks Julian :) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
