Prevent maximize/minimize/fullscreen-ize window in trusted pinned mode.

ash/common/wm/maximize_mode/maximize_mode_window_state.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/maximize_mode/maximize_mode_window_state.h"
 
 #include <utility>
 
 #include "ash/common/wm/maximize_mode/maximize_mode_window_manager.h"
 #include "ash/common/wm/window_animation_types.h"
@@ skipping 115 matching lines @@
 
   defer_bounds_updates_ = defer_bounds_updates;
   if (!defer_bounds_updates_)
     UpdateBounds(window_->GetWindowState(), true);
 }
 
 void MaximizeModeWindowState::OnWMEvent(wm::WindowState* window_state,
                                         const wm::WMEvent* event) {
   switch (event->type()) {
     case wm::WM_EVENT_TOGGLE_FULLSCREEN:
+      if (window_state->IsTrustedPinned())
+        return;

[oshima, 2016/12/21 01:38:58]

FYI: ARC windows are no longer using this class. We may want to remove pin code,
and add assert to prevent using pinned, unless we want to use PINn'ed state for
cros windows.

[hidehiko, 2016/12/21 06:57:30]

Thanks, so reverted this file.
Let's address removing pinned code from this file separately.

       ToggleFullScreen(window_state, window_state->delegate());
       break;
     case wm::WM_EVENT_FULLSCREEN:
+      if (window_state->IsTrustedPinned())
+        return;
       UpdateWindow(window_state, wm::WINDOW_STATE_TYPE_FULLSCREEN, true);
       break;
     case wm::WM_EVENT_PIN:
       if (!WmShell::Get()->IsPinned())
         UpdateWindow(window_state, wm::WINDOW_STATE_TYPE_PINNED, true);
       break;
     case wm::WM_EVENT_TRUSTED_PIN:
       if (!WmShell::Get()->IsPinned())
         UpdateWindow(window_state, wm::WINDOW_STATE_TYPE_TRUSTED_PINNED, true);
       break;
     case wm::WM_EVENT_TOGGLE_MAXIMIZE_CAPTION:
     case wm::WM_EVENT_TOGGLE_VERTICAL_MAXIMIZE:
     case wm::WM_EVENT_TOGGLE_HORIZONTAL_MAXIMIZE:
     case wm::WM_EVENT_TOGGLE_MAXIMIZE:
+    case wm::WM_EVENT_MAXIMIZE:
+      if (window_state->IsTrustedPinned())
+        return;
+    // Fall through.
     case wm::WM_EVENT_CYCLE_SNAP_DOCK_LEFT:
     case wm::WM_EVENT_CYCLE_SNAP_DOCK_RIGHT:
     case wm::WM_EVENT_CENTER:
     case wm::WM_EVENT_SNAP_LEFT:
     case wm::WM_EVENT_SNAP_RIGHT:
     case wm::WM_EVENT_NORMAL:
-    case wm::WM_EVENT_MAXIMIZE:
     case wm::WM_EVENT_DOCK:
       UpdateWindow(window_state, GetMaximizedOrCenteredWindowType(window_state),
                    true);
       return;
     case wm::WM_EVENT_MINIMIZE:
+      if (window_state->IsTrustedPinned())
+        return;
       UpdateWindow(window_state, wm::WINDOW_STATE_TYPE_MINIMIZED, true);
       return;
     case wm::WM_EVENT_SHOW_INACTIVE:
       return;
     case wm::WM_EVENT_SET_BOUNDS:
       if (window_state->allow_set_bounds_in_maximized()) {
         window_state->SetBoundsConstrained(
             static_cast<const wm::SetBoundsEvent*>(event)->requested_bounds());
       } else if (current_state_type_ == wm::WINDOW_STATE_TYPE_MAXIMIZED) {
         // Having a maximized window, it could have been created with an empty
@@ skipping 153 matching lines @@
       // avoid flashing.
       if (window_state->IsMaximized())
         window_state->SetBoundsDirectCrossFade(bounds_in_parent);
       else
         window_state->SetBoundsDirectAnimated(bounds_in_parent);
     }
   }
 }
 
 }  // namespace ash