MD History: Move queryState to be managed by history-router

chrome/browser/resources/md_history/router.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-router',
 
   properties: {
     selectedPage: {
       type: String,
       observer: 'serializePath_',
       notify: true,
     },
 
+    /** @type {QueryState} */
     queryState: {
       type: Object,
       notify: true,
+      value: function() {
+        // TODO(tsergeant: Move this initialization into query-manager.

[calamity, 2017/01/17 06:22:10]

Just wondering, why's this hard to do this patch?

[tsergeant, 2017/01/18 03:36:00]

It's an initialization order thing.

If queryState was initialized in query-manager (which initialises first), when
router initializes it will see the top-down command to set searchTerm to ''
before it sees the bottom-up command to set searchTerm to whatever is in the
URL. This means that query strings in the URL get ignored.

I'm honestly not 100% sure why this isn't a problem in the next patch. I'll dig
into it a bit more and let you know.

+        return {
+          // Whether the most recent query was incremental.
+          incremental: false,
+          // A query is initiated by page load.
+          querying: true,
+          queryingDisabled: false,
+          _range: HistoryRange.ALL_TIME,
+          searchTerm: '',
+          groupedOffset: 0,
+
+          set range(val) {
+            this._range = Number(val);
+          },
+          get range() {
+            return this._range;
+          },
+        };
+      },
     },
 
     path_: {
       type: String,
       observer: 'pathChanged_',
     },
 
     queryParams_: Object,
   },
 
@@ skipping 26 matching lines @@
   /** @private */
   queryParamsChanged_: function() {
     this.set('queryState.searchTerm', this.queryParams_.q || '');
   },
 
   /** @private */
   searchTermChanged_: function() {
     this.set('queryParams_.q', this.queryState.searchTerm || null);
   },
 });