Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 259003005: Revert 266157 "Extend DOMActivityLogger interface for upcoming c..." (Closed)

Created:
6 years, 7 months ago by awong
Modified:
6 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 266157 "Extend DOMActivityLogger interface for upcoming c..." Doing this per request from matthewyuan. B=367506 > Extend DOMActivityLogger interface for upcoming change > > In order to reduce pain (hopefully to zero) for sheriffs and fellow developers > who prefer their trees green rather than red, let's make landing the change > at https://codereview.chromium.org/213783002/ as safe as possible. > > Step 1: This CL. Extend DOMActivityLogger with new methods for logGetter, > logSetter, and logMethod, which have the same functionality as the current > log() method. > Step 2: https://codereview.chromium.org/213783002/ - The implementation change > in blink to switch from using log() to using logX. > Step 3: Cleanup -- remove old log method from chrome. > > BUG=356890 > > Review URL: https://codereview.chromium.org/247953008 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -130 lines) Patch
M trunk/src/chrome/common/extensions/ad_injection_constants.h View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/chrome/common/extensions/ad_injection_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/renderer/extensions/dom_activity_logger.h View 3 chunks +7 lines, -39 lines 0 comments Download
M trunk/src/chrome/renderer/extensions/dom_activity_logger.cc View 4 chunks +29 lines, -87 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
awong
6 years, 7 months ago (2014-04-28 17:44:04 UTC) #1
awong
6 years, 7 months ago (2014-04-28 17:44:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r266599.

Powered by Google App Engine
This is Rietveld 408576698