Issue 25900003: Hoist <template> in <head> if encountered in AfterHead insertion mode

Issue 25900003: Hoist <template> in <head> if encountered in AfterHead insertion mode (Closed)

Created:
7 years, 2 months ago by rafaelw

Modified:
7 years, 2 months ago

Reviewers:
rafaelw1, adamk, abarth-chromium

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, adamk

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Hoist <template> in <head> if encountered in AfterHead insertion mode R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159064

Patch Set 1 #

Total comments: 4

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
	M	LayoutTests/html5lib/resources/template.dat	View		1 chunk	+21 lines, -0 lines	0 comments	Download
	M	Source/core/html/parser/HTMLTreeBuilder.cpp	View		3 chunks	+6 lines, -2 lines	4 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

adamk

Your CL description says this is about <template> but your changes to resetInsertionModeAppropriately() don't all ...

7 years, 2 months ago (2013-10-03 21:51:37 UTC) #2

rafaelw

Sorry. This bug should help explain it: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23002 (It's partially spec'd)

7 years, 2 months ago (2013-10-03 21:53:38 UTC) #3

rafaelw

https://codereview.chromium.org/25900003/diff/1/Source/core/html/parser/HTMLTreeBuilder.cpp File Source/core/html/parser/HTMLTreeBuilder.cpp (left): https://codereview.chromium.org/25900003/diff/1/Source/core/html/parser/HTMLTreeBuilder.cpp#oldcode1607 Source/core/html/parser/HTMLTreeBuilder.cpp:1607: ASSERT(isParsingFragment()); No, it wasn't wrong before. It's just the ...

7 years, 2 months ago (2013-10-03 21:55:34 UTC) #4

rafaelw1

Woops. Sorry. "Adam confusion". I meant to make abarth the reviewer and cc adamk. On ...

7 years, 2 months ago (2013-10-03 21:58:35 UTC) #6

rafaelw

abarth: PTAL. If this lgty, then I just assume go ahead and be consistent with ...

7 years, 2 months ago (2013-10-04 18:23:25 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/25900003/1

7 years, 2 months ago (2013-10-04 18:39:32 UTC) #9

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=9015

7 years, 2 months ago (2013-10-04 20:58:47 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/25900003/1

7 years, 2 months ago (2013-10-07 20:04:12 UTC) #11

Message was sent while issue was closed.

Change committed as 159064

Expand Messages | Collapse Messages