Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: net/quic/core/crypto/proof_source.h

Issue 2589983002: Create a QUIC wrapper around scoped_refptr. (Closed)
Patch Set: rm = nullptr Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/crypto_server_test.cc ('k') | net/quic/core/crypto/quic_compressed_certs_cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/proof_source.h
diff --git a/net/quic/core/crypto/proof_source.h b/net/quic/core/crypto/proof_source.h
index 88bf2d391664a42d1cce945d1ba49b947909f627..8db52f7a66e682c43a20a11756855732018cd69e 100644
--- a/net/quic/core/crypto/proof_source.h
+++ b/net/quic/core/crypto/proof_source.h
@@ -9,10 +9,10 @@
#include <string>
#include <vector>
-#include "base/memory/ref_counted.h"
#include "net/quic/core/crypto/quic_crypto_proof.h"
#include "net/quic/core/quic_packets.h"
#include "net/quic/platform/api/quic_export.h"
+#include "net/quic/platform/api/quic_reference_counted.h"
#include "net/quic/platform/api/quic_socket_address.h"
namespace net {
@@ -23,16 +23,15 @@ class QUIC_EXPORT_PRIVATE ProofSource {
public:
// Chain is a reference-counted wrapper for a std::vector of std::stringified
// certificates.
- struct QUIC_EXPORT_PRIVATE Chain : public base::RefCounted<Chain> {
+ struct QUIC_EXPORT_PRIVATE Chain : public QuicReferenceCounted {
explicit Chain(const std::vector<std::string>& certs);
const std::vector<std::string> certs;
- private:
- friend class base::RefCounted<Chain>;
-
- virtual ~Chain();
+ protected:
+ ~Chain() override;
+ private:
DISALLOW_COPY_AND_ASSIGN(Chain);
};
@@ -65,7 +64,7 @@ class QUIC_EXPORT_PRIVATE ProofSource {
// any, gathered during the operation of GetProof. If no stats are
// available, this will be nullptr.
virtual void Run(bool ok,
- const scoped_refptr<Chain>& chain,
+ const QuicReferenceCountedPointer<Chain>& chain,
const QuicCryptoProof& proof,
std::unique_ptr<Details> details) = 0;
@@ -109,7 +108,7 @@ class QUIC_EXPORT_PRIVATE ProofSource {
QuicVersion quic_version,
base::StringPiece chlo_hash,
const QuicTagVector& connection_options,
- scoped_refptr<Chain>* out_chain,
+ QuicReferenceCountedPointer<Chain>* out_chain,
QuicCryptoProof* out_proof) = 0;
// Async version of GetProof with identical semantics, except that the results
« no previous file with comments | « net/quic/core/crypto/crypto_server_test.cc ('k') | net/quic/core/crypto/quic_compressed_certs_cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698