Simplified CPU/CpuFeatures a bit.

src/arm/assembler-arm.cc

Index: src/arm/assembler-arm.cc
diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc
index 5c1c31126d1129e7c838f41648ba3fa3fb95a1f6..7767fd21d0432bd4541f327499b5ae982f0faa93 100644
--- a/src/arm/assembler-arm.cc
+++ b/src/arm/assembler-arm.cc
@@ -48,7 +48,6 @@ namespace internal {
 #ifdef DEBUG
 bool CpuFeatures::initialized_ = false;
 #endif
-bool CpuFeatures::hint_creating_snapshot_ = false;
 unsigned CpuFeatures::supported_ = 0;
 unsigned CpuFeatures::found_by_runtime_probing_only_ = 0;
 unsigned CpuFeatures::cross_compile_ = 0;
@@ -101,22 +100,6 @@ const char* DwVfpRegister::AllocationIndexToString(int index) {
 }
 
 
-void CpuFeatures::SetHintCreatingSnapshot() {
-  hint_creating_snapshot_ = true;
-}
-
-
-void CpuFeatures::ProbeWithoutIsolate() {
-  Probe(hint_creating_snapshot_);
-}
-
-
-void CpuFeatures::Probe() {
-  // The Serializer can only be queried after isolate initialization.
-  Probe(Serializer::enabled());
-}
-
-
 void CpuFeatures::Probe(bool serializer_enabled) {
   uint64_t standard_features = static_cast<unsigned>(
       OS::CpuFeaturesImpliedByPlatform()) | CpuFeaturesImpliedByCompiler();
@@ -133,8 +116,6 @@ void CpuFeatures::Probe(bool serializer_enabled) {
 
   if (serializer_enabled) {
     // No probing for features if we might serialize (generate snapshot).
-    printf("   ");
-    PrintFeatures();

[vincent.belliard, 2014/04/29 15:25:17]

Why did you removed this display?
It was very useful to check during the build that the snapshot was generated
with the good options.

[Sven Panne, 2014/04/30 06:11:16]

It is not done for other platforms, it is printed with --help, anyway (twice
before), and I don't think the current approach of #ifdef'ing code just for ARM
(where the other PrintFeatures is residing) directly below src/ is a good idea,
this has to go away, too. ARM-specififc stuff should be below src/arm, the
current approach is a hack.

     return;
   }