Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2589923002: Add a hardcoded list of methods that need a "Get" prefix. (Closed)
Patch Set: Remove commented-out lines. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
index 28020337bb25359f3d6a8622660954de551b975d..2503ce796f6b2d6f46088fa0fb9ed8d850b82c6d 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
@@ -176,6 +176,10 @@ class BitVector {
class Baz {};
class FooBar {};
+ // Should be renamed to GetReadyState, because of
+ // IsMethodNameLikelyToConflictWithTypeName heuristic.
+ int readyState() { return 123; }
+
template <typename T>
class MyRefPtr {};

Powered by Google App Engine
This is Rietveld 408576698