Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2589923002: Add a hardcoded list of methods that need a "Get" prefix. (Closed)
Patch Set: Rebasing... Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gen/thing.h" 5 #include "gen/thing.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 8
9 class InterfaceOutsideOfBlink { 9 class InterfaceOutsideOfBlink {
10 public: 10 public:
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 }; 170 };
171 171
172 class BitVector { 172 class BitVector {
173 public: 173 public:
174 class OutOfLineBits {}; 174 class OutOfLineBits {};
175 enum Foo { Blah }; 175 enum Foo { Blah };
176 struct Bar {}; 176 struct Bar {};
177 class Baz {}; 177 class Baz {};
178 class FooBar {}; 178 class FooBar {};
179 179
180 // Should be renamed to GetReadyState, because of
181 // ShouldPrefixFunctionName heuristic.
182 int readyState() { return 123; }
183
180 template <typename T> 184 template <typename T>
181 class MyRefPtr {}; 185 class MyRefPtr {};
182 186
183 // Naive renaming will break the build, by leaving return type the same 187 // Naive renaming will break the build, by leaving return type the same
184 // as the method name - to avoid this "Get" prefix needs to be prepended 188 // as the method name - to avoid this "Get" prefix needs to be prepended
185 // as suggested in https://crbug.com/582312#c17. 189 // as suggested in https://crbug.com/582312#c17.
186 const OutOfLineBits* outOfLineBits() const { return nullptr; } 190 const OutOfLineBits* outOfLineBits() const { return nullptr; }
187 Foo foo() { return Blah; } 191 Foo foo() { return Blah; }
188 const Bar& bar() const { return m_bar; } 192 const Bar& bar() const { return m_bar; }
189 MyRefPtr<Baz> baz() { return MyRefPtr<Baz>(); } 193 MyRefPtr<Baz> baz() { return MyRefPtr<Baz>(); }
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 static void method(); 263 static void method();
260 }; 264 };
261 265
262 } // namespace internal 266 } // namespace internal
263 267
264 } // namespace blink 268 } // namespace blink
265 269
266 // https://crbug.com/640688 - need to rewrite method name below. 270 // https://crbug.com/640688 - need to rewrite method name below.
267 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {} 271 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {}
268 void blink::internal::InternalClass::method() {} 272 void blink::internal::InternalClass::method() {}
OLDNEW
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698