Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2589913002: Clear the owner element's widget in Document::shutdown(). (Closed)

Created:
4 years ago by dcheng
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Clear the owner element's widget in Document::shutdown(). FrameView::dispose() doesn't guarantee that the owner's widget is cleared and this could be problematic when it's overwritten in LocalFrame::createView() a short time later. BUG=673170 Review-Url: https://codereview.chromium.org/2563313002 Cr-Commit-Position: refs/heads/master@{#438977} (cherry picked from commit 71b91a424a00dce5ff5ff4cf2e7b52fc70136f36) Committed: https://chromium.googlesource.com/chromium/src/+/a7a51f270ce442c7292abb84e2e4941f1c9c6199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dcheng
4 years ago (2016-12-19 18:29:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7a51f270ce442c7292abb84e2e4941f1c9c6199 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698