third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h - Issue 2589893002: [Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h

Issue 2589893002: [Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions (Closed)

Patch Set: more Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/mediasession/MediaSession.idl ('K') | « third_party/WebKit/Source/modules/mediasession/MediaSession.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h

diff --git a/third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h b/third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h

index d8bdf80af41384039c89d714154702f8863b14a6..74a3b935a5bccb18f484c4dee4b49c67804bf63d 100644

--- a/third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h

+++ b/third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h

@@ -5,6 +5,7 @@

#ifndef NavigatorMediaSession_h

#define NavigatorMediaSession_h

+#include "bindings/core/v8/ScriptState.h"

mlamouri (slow - plz ping) 2016/12/20 13:25:58 why?

Zhiqiang Zhang (Slow) 2016/12/20 13:53:06 This is because I removed some #include from Media

#include "core/frame/Navigator.h"

#include "modules/mediasession/MediaSession.h"

#include "platform/Supplementable.h"

« third_party/WebKit/Source/modules/mediasession/MediaSession.idl ('K') | « third_party/WebKit/Source/modules/mediasession/MediaSession.idl ('k') | no next file » | no next file with comments »