Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html

Issue 2589893002: [Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions (Closed)
Patch Set: more Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html
diff --git a/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html b/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html
index 16752a98afe740fad47c0937399564c817a65bb4..d01c2fc0629be08dee0a56b89497db9ceed5d945 100644
--- a/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html
+++ b/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html
@@ -56,31 +56,31 @@ async_test(function(t) {
}));
// Setting handlers
- window.navigator.mediaSession.onresize = _ => {}; // Unknown event.
- window.navigator.mediaSession.onplay = _ => {};
- window.navigator.mediaSession.onpause = _ => {};
- window.navigator.mediaSession.onprevioustrack = _ => {};
- window.navigator.mediaSession.onnexttrack = _ => {};
- window.navigator.mediaSession.onseekbackward = _ => {};
- window.navigator.mediaSession.onseekforward = _ => {};
+ // window.navigator.mediaSession.setActionCallback("resize", _ => {}); // Unknown event.
+ window.navigator.mediaSession.setActionCallback("play", _ => {});
+ window.navigator.mediaSession.setActionCallback("pause", _ => {});
+ window.navigator.mediaSession.setActionCallback("previoustrack", _ => {});
+ window.navigator.mediaSession.setActionCallback("nexttrack", _ => {});
+ window.navigator.mediaSession.setActionCallback("seekbackward", _ => {});
+ window.navigator.mediaSession.setActionCallback("seekforward", _ => {});
// Resetting handlers
- window.navigator.mediaSession.onresize = _ => {}; // Unknown event.
- window.navigator.mediaSession.onplay = _ => {};
- window.navigator.mediaSession.onpause = _ => {};
- window.navigator.mediaSession.onprevioustrack = _ => {};
- window.navigator.mediaSession.onnexttrack = _ => {};
- window.navigator.mediaSession.onseekbackward = _ => {};
- window.navigator.mediaSession.onseekforward = _ => {};
+ // window.navigator.mediaSession.setActionCallback("resize", _ => {}); // Unknown event.
+ window.navigator.mediaSession.setActionCallback("play", _ => {});
+ window.navigator.mediaSession.setActionCallback("pause", _ => {});
+ window.navigator.mediaSession.setActionCallback("previoustrack", _ => {});
+ window.navigator.mediaSession.setActionCallback("nexttrack", _ => {});
+ window.navigator.mediaSession.setActionCallback("seekbackward", _ => {});
+ window.navigator.mediaSession.setActionCallback("seekforward", _ => {});
// Unsetting handlers
- window.navigator.mediaSession.onresize = null; // Unknown event.
- window.navigator.mediaSession.onplay = null;
- window.navigator.mediaSession.onpause = null;
- window.navigator.mediaSession.onprevioustrack = null;
- window.navigator.mediaSession.onnexttrack = null;
- window.navigator.mediaSession.onseekbackward = null;
- window.navigator.mediaSession.onseekforward = null;
+ // window.navigator.mediaSession.setActionCallback("resize", null); // Unknown event.
+ window.navigator.mediaSession.setActionCallback("play", null);
+ window.navigator.mediaSession.setActionCallback("pause", null);
+ window.navigator.mediaSession.setActionCallback("previoustrack", null);
+ window.navigator.mediaSession.setActionCallback("nexttrack", null);
+ window.navigator.mediaSession.setActionCallback("seekbackward", null);
+ window.navigator.mediaSession.setActionCallback("seekforward", null);
});
}, "test that setting event handler notifies the mojo service");

Powered by Google App Engine
This is Rietveld 408576698