Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: content/browser/media/session/media_session_service_impl.cc

Issue 2589893002: [Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions (Closed)
Patch Set: more Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session_service_impl.cc
diff --git a/content/browser/media/session/media_session_service_impl.cc b/content/browser/media/session/media_session_service_impl.cc
index 1d93af395a1768bfd000c226d51b0d862230ebf8..7e92663355d4eb85175c94603ad72bb099feb913 100644
--- a/content/browser/media/session/media_session_service_impl.cc
+++ b/content/browser/media/session/media_session_service_impl.cc
@@ -68,6 +68,10 @@ void MediaSessionServiceImpl::SetMetadata(
void MediaSessionServiceImpl::EnableAction(
blink::mojom::MediaSessionAction action) {
+ // Action already enabled
+ if (actions_.find(action) != actions_.end())
+ return;
+
actions_.insert(action);
MediaSessionImpl* session = GetMediaSession();
if (session)
@@ -76,6 +80,10 @@ void MediaSessionServiceImpl::EnableAction(
void MediaSessionServiceImpl::DisableAction(
blink::mojom::MediaSessionAction action) {
+ // Action already disabled
+ if (actions_.find(action) == actions_.end())
+ return;
+
actions_.erase(action);
MediaSessionImpl* session = GetMediaSession();
if (session)

Powered by Google App Engine
This is Rietveld 408576698