third_party/WebKit/Source/bindings/modules/v8/custom/V8MediaSessionCustom.cpp - Issue 2589893002: [Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8MediaSessionCustom.cpp

Issue 2589893002: [Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions (Closed)

Patch Set: more Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "bindings/modules/v8/V8MediaSession.h"

	6

	7 #include "bindings/core/v8/V8DOMWrapper.h"

	8 #include "modules/mediasession/MediaSession.h"

	9

	10 namespace blink {

	11

	12 void V8MediaSession::visitDOMWrapperCustom(

	13 v8::Isolate* isolate,

	14 ScriptWrappable* scriptWrappable,

	15 const v8::Persistent<v8::Object>& wrapper) {

	16 MediaSession* mediaSession = scriptWrappable->toImpl<MediaSession>();

	17 mediaSession->setV8ReferencesForCallbacks(isolate, wrapper);
	mlamouri (slow - plz ping) 2016/12/20 13:25:57 nit: you can probably do this in one line. nit: you can probably do this in one line. Zhiqiang Zhang (Slow) 2016/12/20 13:53:06 Done. Show quoted text On 2016/12/20 13:25:57, mlamouri wrote: > nit: you can probably do this in one line. Done.
	18 }

	19

	20 } // namespace blink

OLD	NEW