third_party/WebKit/LayoutTests/media/mediasession/mediasession-setactionhandler.html - Issue 2589893002: [Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/mediasession/mediasession-setactionhandler.html

Issue 2589893002: [Blink>MediaSession] Use setActionCallback() instead of event listeners for media control actions (Closed)

Patch Set: rebased and more tests Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html » ('j') | third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Test that setting MediaSession event handler should notify the service</t itle>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6

	7 test(function(t) {

	8 window.navigator.mediaSession.setActionHandler("play", null);

	9 window.navigator.mediaSession.setActionHandler("pause", null);

	10 window.navigator.mediaSession.setActionHandler("previoustrack", null);

	11 window.navigator.mediaSession.setActionHandler("nexttrack", null);

	12 window.navigator.mediaSession.setActionHandler("seekbackward", null);

	13 window.navigator.mediaSession.setActionHandler("seekforward", null);

	14 }, "test that setActionHandler() can be executed for supported actions");
	mlamouri (slow - plz ping) 2016/12/23 12:13:58 nit: s/test/Test/ nit: s/test/Test/ Zhiqiang Zhang (Slow) 2017/01/05 09:29:15 Done. Show quoted text On 2016/12/23 12:13:58, mlamouri wrote: > nit: s/test/Test/ Done.
	15

	16 test(function(t) {

	17 assert_throws(

	18 new TypeError("Failed to execute 'setActionHandler' on 'MediaSession':" +

	19 "The provided value 'invalid' is not a valid enum value" +

	20 "of type MediaSessionAction."),

	21 _ => { window.navigator.mediaSession.setActionHandler("invalid", null); }) ;

	22 }, "test that setActionHandler() throws exception for unsupported actions");
	mlamouri (slow - plz ping) 2016/12/23 12:13:58 ditto ditto Zhiqiang Zhang (Slow) 2017/01/05 09:29:15 Done. Show quoted text On 2016/12/23 12:13:58, mlamouri wrote: > ditto Done.
	23

	24 </script>

OLD	NEW