Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: mojo/public/cpp/bindings/associated_interface_ptr.h

Issue 2589663003: mojo:: Rename mojo::GetProxy() to mojo::MakeRequest() (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/js/tests/js_to_cpp_tests.cc ('k') | mojo/public/cpp/bindings/binding_set.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/associated_interface_ptr.h
diff --git a/mojo/public/cpp/bindings/associated_interface_ptr.h b/mojo/public/cpp/bindings/associated_interface_ptr.h
index e5c068e2a6fcf8d46a29dc5129a011a17c66497b..e760c7d34a053bf9ec57d9386dd15ecab1f12f63 100644
--- a/mojo/public/cpp/bindings/associated_interface_ptr.h
+++ b/mojo/public/cpp/bindings/associated_interface_ptr.h
@@ -212,7 +212,7 @@ class AssociatedInterfacePtr {
// as soon as the request is sent, |ptr| is usable. There is no need to wait
// until the request is bound to an implementation at the remote side.
template <typename Interface>
-AssociatedInterfaceRequest<Interface> GetProxy(
+AssociatedInterfaceRequest<Interface> MakeRequest(
AssociatedInterfacePtr<Interface>* ptr,
AssociatedGroup* group,
scoped_refptr<base::SingleThreadTaskRunner> runner =
@@ -228,7 +228,7 @@ AssociatedInterfaceRequest<Interface> GetProxy(
// Creates an associated interface proxy in its own AssociatedGroup.
template <typename Interface>
-AssociatedInterfaceRequest<Interface> GetProxyForTesting(
+AssociatedInterfaceRequest<Interface> MakeRequestForTesting(
AssociatedInterfacePtr<Interface>* ptr,
scoped_refptr<base::SingleThreadTaskRunner> runner =
base::ThreadTaskRunnerHandle::Get()) {
@@ -264,7 +264,7 @@ void GetDummyProxyForTesting(AssociatedInterfacePtr<Interface>* proxy) {
internal::MultiplexRouter::MULTI_INTERFACE,
false, base::ThreadTaskRunnerHandle::Get());
std::unique_ptr<AssociatedGroup> group = router->CreateAssociatedGroup();
- GetProxy(proxy, group.get());
+ MakeRequest(proxy, group.get());
}
} // namespace mojo
« no previous file with comments | « mojo/edk/js/tests/js_to_cpp_tests.cc ('k') | mojo/public/cpp/bindings/binding_set.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698