Issue 2589583002: [ash-md] Adds VPN network status indicators in system menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2589583002: [ash-md] Adds VPN network status indicators in system menu (Closed)

Created:
4 years ago by bruthig

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

[ash-md] Adds VPN network status indicators in system menu BUG=674174 Test=Connect to a VPN network. Verify that connected network has "Connected" text indicator. Review-Url: https://codereview.chromium.org/2571943002 Cr-Commit-Position: refs/heads/master@{#438560} (cherry picked from commit e1c1bf58180cee3eae3a380f1f53ddb22bbedede) Committed: https://chromium.googlesource.com/chromium/src/+/7ee09a0a7ddd52c7cb4647b809ad78592557ccc6

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -14 lines)			Patch
	M	ash/common/system/chromeos/network/vpn_list_view.cc	View		5 chunks	+46 lines, -14 lines	0 comments	Download

Total messages: 2 (1 generated)

bruthig

4 years ago (2016-12-18 22:41:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7ee09a0a7ddd52c7cb4647b809ad78592557ccc6.