Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 258953009: Refactor calls to CALL_HEAP_FUNCTION. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Refactor calls to CALL_HEAP_FUNCTION. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21036

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase and addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -51 lines) Patch
M src/api.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/factory.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M src/factory.cc View 1 5 chunks +24 lines, -21 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 chunks +2 lines, -20 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 7 months ago (2014-04-28 14:57:35 UTC) #1
mvstanton
One name comment, and then LGTM. https://codereview.chromium.org/258953009/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/258953009/diff/1/src/objects.cc#newcode6058 src/objects.cc:6058: copy = isolate->factory()->CopyJSObjectWithMemento(object, ...
6 years, 7 months ago (2014-04-28 15:41:10 UTC) #2
Yang
6 years, 7 months ago (2014-04-29 07:02:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21036 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698